The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Parameter 'optional' is not assigned and could be declared final | 76 |
| Parameter 'type' is not assigned and could be declared final | 76 |
| Parameter 'cfg' is not assigned and could be declared final | 106 |
| Avoid using Literals in Conditional Statements | 112 |
| Avoid empty catch blocks | 115 |
| Parameter 'cfg' is not assigned and could be declared final | 132 |
| Parameter 'cfg' is not assigned and could be declared final | 152 |
| Avoid using Literals in Conditional Statements | 158 |
| Avoid empty catch blocks | 162 |
| Parameter 'cfg' is not assigned and could be declared final | 179 |
| Local variable 'result' could be declared final | 180 |
| Parameter 'cfg' is not assigned and could be declared final | 193 |
| Local variable 'params' could be declared final | 196 |
| Local variable 'param' could be declared final | 198 |
| Local variable 'map' could be declared final | 201 |
| Avoid using Literals in Conditional Statements | 202 |
| Deeply nested if..then statements are hard to read | 203 - 204 |
| Avoid using Literals in Conditional Statements | 203 |
| Avoid instantiating new objects inside loops | 204 |
| Parameter 'param' is not assigned and could be declared final | 225 |
| Parameter 'cfg' is not assigned and could be declared final | 225 |
| Local variable 'keyval' could be declared final | 232 |
| Prefer StringBuffer over += for concatenating strings | 236 |
| Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| Private field 'm_objId' could be made final; it is only initialized in the declaration or constructor. | 265 |
| Private field 'm_objDest' could be made final; it is only initialized in the declaration or constructor. | 268 |
| Parameter 'id' is not assigned and could be declared final | 276 |
| Parameter 'dest' is not assigned and could be declared final | 276 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 67 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 42 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 67 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 75 |
| Avoid modifiers which are implied by the context | 83 |
| Avoid modifiers which are implied by the context | 90 |
| Avoid modifiers which are implied by the context | 97 |
| Avoid modifiers which are implied by the context | 104 |
| Avoid modifiers which are implied by the context | 113 |
| Avoid modifiers which are implied by the context | 121 |
| Avoid modifiers which are implied by the context | 129 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 41 |
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 65 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 35 - 119 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'storage' is not assigned and could be declared final | 55 |
| Use block level rather than method level synchronization | 65 - 67 |
| Use block level rather than method level synchronization | 76 - 79 |
| Parameter 'storage' is not assigned and could be declared final | 76 |
| Use block level rather than method level synchronization | 86 - 88 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 136 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'cfg' is not assigned and could be declared final | 50 |
| Parameter 'verifierRepo' is not assigned and could be declared final | 61 |
| Parameter 'cfg' is not assigned and could be declared final | 61 |
| Use block level rather than method level synchronization | 71 - 73 |
| Use block level rather than method level synchronization | 82 - 85 |
| Parameter 'cfg' is not assigned and could be declared final | 82 |
| Use block level rather than method level synchronization | 92 - 94 |
| Use block level rather than method level synchronization | 122 - 125 |
| Parameter 'verifierRepo' is not assigned and could be declared final | 122 |
| Parameter 'cfg' is not assigned and could be declared final | 122 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 41 - 176 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Private field 'm_objVerifierRepo' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Private field 'm_objTimeRepo' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Parameter 'cfg' is not assigned and could be declared final | 69 |
| Use block level rather than method level synchronization | 84 - 89 |
| Parameter 'config' is not assigned and could be declared final | 84 |
| Avoid using Literals in Conditional Statements | 85 |
| Parameter 'specUri' is not assigned and could be declared final | 103 |
| Found 'DD'-anomaly for variable 'result' (lines '104'-'106'). | 104 - 106 |
| Local variable 'id' could be declared final | 107 |
| Parameter 'uuid' is not assigned and could be declared final | 120 |
| Found 'DD'-anomaly for variable 'result' (lines '121'-'123'). | 121 - 123 |
| Avoid if (x != y) ..; else ..; | 124 - 129 |
| Avoid using Literals in Conditional Statements | 124 |
| Parameter 'uuid' is not assigned and could be declared final | 139 |
| Found 'DD'-anomaly for variable 'result' (lines '140'-'142'). | 140 - 142 |
| Avoid if (x != y) ..; else ..; | 143 - 147 |
| Avoid using Literals in Conditional Statements | 143 |
| Local variable 'currentTime' could be declared final | 157 |
| Found 'DU'-anomaly for variable 'currentTime' (lines '157'-'174'). | 157 - 174 |
| Local variable 'iter' could be declared final | 159 |
| Local variable 'candidates' could be declared final | 160 |
| Local variable 'key' could be declared final | 162 |
| Local variable 'val' could be declared final | 163 |
| Violation | Line |
|---|---|
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Private field 'm_strStructId' could be made final; it is only initialized in the declaration or constructor. | 70 |
| Parameter 'specUri' is not assigned and could be declared final | 84 |
| Parameter 'cfg' is not assigned and could be declared final | 84 |
| Avoid using Literals in Conditional Statements | 97 |
| Local variable 'result' could be declared final | 113 |
| Parameter 'msg' is not assigned and could be declared final | 136 |
| Local variable 'returnString' could be declared final | 139 |
| Avoid reassigning parameters such as 'resultUri' | 151 |
| Parameter 'proof' is not assigned and could be declared final | 151 |
| Found 'DD'-anomaly for variable 'result' (lines '154'-'162'). | 154 - 162 |
| Local variable 'encs' could be declared final | 158 |
| Local variable 'isValid' could be declared final | 160 |
| Avoid using Literals in Conditional Statements | 166 |
| Parameter 'str' is not assigned and could be declared final | 184 |
| Found 'DD'-anomaly for variable 'result' (lines '187'-'189'). | 187 - 189 |
| Parameter 'enc' is not assigned and could be declared final | 207 |
| Found 'DD'-anomaly for variable 'result' (lines '210'-'213'). | 210 - 213 |
| Avoid using Literals in Conditional Statements | 212 |
| Found 'DD'-anomaly for variable 'result' (lines '229'-'232'). | 229 - 232 |
| Avoid using Literals in Conditional Statements | 231 |
| Found 'DD'-anomaly for variable 'result' (lines '248'-'254'). | 248 - 254 |
| Avoid using Literals in Conditional Statements | 250 |
| Local variable 'values' could be declared final | 252 |
| Avoid using Literals in Conditional Statements | 253 |
| Local variable 'iter' could be declared final | 255 |
| Local variable 'key' could be declared final | 257 |
| Avoid instantiating new objects inside loops | 260 |
| Local variable 'result' could be declared final | 285 |
| Avoid using Literals in Conditional Statements | 287 |
| Local variable 'encs' could be declared final | 289 |
| Parameter 'name' is not assigned and could be declared final | 305 |
| Found 'DD'-anomaly for variable 'result' (lines '308'-'311'). | 308 - 311 |
| Local variable 'result' could be declared final | 327 |
| Avoid using Literals in Conditional Statements | 329 |
| Local variable 'values' could be declared final | 331 |
| Local variable 'iter' could be declared final | 332 |
| Local variable 'key' could be declared final | 334 |
| Parameter 'resultUri' is not assigned and could be declared final | 350 |
| Violation | Line |
|---|---|
| Private field 'm_objKey' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'm_strVal' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Parameter 'value' is not assigned and could be declared final | 48 |
| Parameter 'key' is not assigned and could be declared final | 48 |
| Violation | Line |
|---|---|
| Parameter 't' is not assigned and could be declared final | 38 |
| Violation | Line |
|---|---|
| Private field 'm_objRepo' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Parameter 'storage' is not assigned and could be declared final | 67 |
| Parameter 'proofUri' is not assigned and could be declared final | 75 |
| Local variable 'service' could be declared final | 81 |
| Avoid if (x != y) ..; else ..; | 82 - 88 |
| Avoid using Literals in Conditional Statements | 82 |
| Local variable 'preq' could be declared final | 83 |
| Avoid using Literals in Conditional Statements | 84 |
| Parameter 'response' is not assigned and could be declared final | 98 |
| Parameter 'resultUri' is not assigned and could be declared final | 99 |
| Avoid using Literals in Conditional Statements | 107 |
| Local variable 'uuid' could be declared final | 108 |
| Local variable 'proofStr' could be declared final | 109 |
| Avoid if (x != y) ..; else ..; | 110 - 134 |
| Local variable 'p' could be declared final | 111 |
| Found 'DU'-anomaly for variable 'p' (lines '111'-'144'). | 111 - 144 |
| Local variable 'service' could be declared final | 112 |
| Avoid if (x != y) ..; else ..; | 113 - 122 |
| Avoid using Literals in Conditional Statements | 113 |
| Local variable 'pres' could be declared final | 114 |
| Avoid using Literals in Conditional Statements | 115 |
| Avoid using Literals in Conditional Statements | 125 |
| Avoid if (x != y) ..; else ..; | 128 - 133 |
| Avoid using Literals in Conditional Statements | 128 |
| Parameter 'response' is not assigned and could be declared final | 150 |
| Parameter 'issuerUri' is not assigned and could be declared final | 151 |
| Parameter 'resultUri' is not assigned and could be declared final | 151 |
| Parameter 'vClient' is not assigned and could be declared final | 151 |
| Avoid using Literals in Conditional Statements | 158 |
| Local variable 'pres' could be declared final | 159 |
| Avoid using Literals in Conditional Statements | 161 |
| Local variable 'service' could be declared final | 163 - 164 |
| Local variable 'encNames' could be declared final | 165 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 166 |
| Local variable 'enc' could be declared final | 167 - 168 |
| Avoid if (x != y) ..; else ..; | 169 - 178 |
| Avoid using Literals in Conditional Statements | 169 |
| Local variable 'vreq' could be declared final | 170 - 172 |
| Avoid using Literals in Conditional Statements | 173 |
| Violation | Line |
|---|---|
| Private field 'm_objRepo' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Parameter 'verifierRepo' is not assigned and could be declared final | 67 |
| Parameter 'cfg' is not assigned and could be declared final | 68 |
| Parameter 'enc' is not assigned and could be declared final | 77 |
| Avoid reassigning parameters such as 'issuer' | 78 |
| Parameter 'replyTo' is not assigned and could be declared final | 78 |
| Parameter 'uuid' is not assigned and could be declared final | 78 |
| Local variable 'service' could be declared final | 85 |
| Avoid using Literals in Conditional Statements | 86 |
| Local variable 'issuerUrl' could be declared final | 87 - 88 |
| Avoid using Literals in Conditional Statements | 89 |
| Avoid using Literals in Conditional Statements | 94 |
| Found 'DD'-anomaly for variable 'strEnc' (lines '102'-'103'). | 102 - 103 |
| Parameter 'response' is not assigned and could be declared final | 121 |
| Avoid using Literals in Conditional Statements | 128 |
| Found 'DD'-anomaly for variable 'statusType' (lines '130'-'132'). | 130 - 132 |
| Found 'DD'-anomaly for variable 'statusType' (lines '130'-'134'). | 130 - 134 |
| Local variable 'uuid' could be declared final | 137 |
| Local variable 'service' could be declared final | 138 |
