The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Private field 'm_strPw' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Parameter 'pw' is not assigned and could be declared final | 43 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 49 - 169 |
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Private field 'm_objProofStore' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Private field 'm_objMsStore' could be made final; it is only initialized in the declaration or constructor. | 64 |
| Private field 'm_objTmpStore' could be made final; it is only initialized in the declaration or constructor. | 67 |
| Private field 'm_objCfgStore' could be made final; it is only initialized in the declaration or constructor. | 70 |
| Parameter 'pw' is not assigned and could be declared final | 81 |
| Avoid using Literals in Conditional Statements | 84 |
| Prefer StringBuffer over += for concatenating strings | 85 |
| Use block level rather than method level synchronization | 103 - 107 |
| Parameter 'pw' is not assigned and could be declared final | 103 |
| Avoid using Literals in Conditional Statements | 104 |
| Assigning an Object to null is a code smell. Consider refactoring. | 164 |
| Assigning an Object to null is a code smell. Consider refactoring. | 165 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 40 - 161 |
| Parameter 'conn' is not assigned and could be declared final | 65 |
| Use block level rather than method level synchronization | 79 - 85 |
| Parameter 'conn' is not assigned and could be declared final | 79 |
| Avoid using Literals in Conditional Statements | 81 |
| Ensure that resources like this Statement object are closed after use | 94 |
| Local variable 'st' could be declared final | 94 |
| Assigning an Object to null is a code smell. Consider refactoring. | 109 |
| Assigning an Object to null is a code smell. Consider refactoring. | 110 |
| Parameter 'value' is not assigned and could be declared final | 118 |
| Parameter 'key' is not assigned and could be declared final | 118 |
| Avoid using Literals in Conditional Statements | 119 |
| Ensure that resources like this Statement object are closed after use | 121 |
| Local variable 'st' could be declared final | 121 |
| Ensure that resources like this Statement object are closed after use | 130 |
| Local variable 'st' could be declared final | 130 |
| Parameter 'key' is not assigned and could be declared final | 144 |
| Found 'DD'-anomaly for variable 'result' (lines '145'-'151'). | 145 - 151 |
| Ensure that resources like this Statement object are closed after use | 148 |
| Local variable 'st' could be declared final | 148 |
| Ensure that resources like this ResultSet object are closed after use | 149 |
| Local variable 'rs' could be declared final | 149 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.HashMap' | 30 |
| A class which only has private constructors should be final | 45 - 223 |
| Parameter 'connector' is not assigned and could be declared final | 70 |
| Use block level rather than method level synchronization | 83 - 88 |
| Parameter 'jdbc' is not assigned and could be declared final | 83 |
| Avoid using Literals in Conditional Statements | 84 |
| Ensure that resources like this Statement object are closed after use | 97 |
| Local variable 'st' could be declared final | 97 |
| Parameter 'credUri' is not assigned and could be declared final | 109 |
| Parameter 'ipkUri' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Found 'DD'-anomaly for variable 'result' (lines '111'-'112'). | 111 - 112 |
| Local variable 'instance' could be declared final | 115 - 116 |
| Ensure that resources like this Statement object are closed after use | 117 |
| Local variable 'st' could be declared final | 117 |
| Parameter 'credUri' is not assigned and could be declared final | 135 |
| Parameter 'ipkUri' is not assigned and could be declared final | 135 |
| Found 'DD'-anomaly for variable 'result' (lines '136'-'146'). | 136 - 146 |
| Ensure that resources like this Statement object are closed after use | 139 |
| Local variable 'st' could be declared final | 139 |
| Ensure that resources like this ResultSet object are closed after use | 140 |
| Local variable 'rs' could be declared final | 140 - 142 |
| Local variable 'val' could be declared final | 144 |
| Avoid using Literals in Conditional Statements | 145 |
| Parameter 'credUri' is not assigned and could be declared final | 164 |
| Parameter 'ipkUri' is not assigned and could be declared final | 164 |
| Ensure that resources like this Statement object are closed after use | 167 |
| Local variable 'st' could be declared final | 167 |
| Local variable 'result' could be declared final | 183 |
| Ensure that resources like this Statement object are closed after use | 186 |
| Local variable 'st' could be declared final | 186 |
| Ensure that resources like this ResultSet object are closed after use | 187 |
| Local variable 'rs' could be declared final | 187 |
| Local variable 'credUri' could be declared final | 189 |
| Local variable 'ipkUri' could be declared final | 190 |
| Local variable 'val' could be declared final | 191 |
| Avoid instantiating new objects inside loops | 193 |
| Assigning an Object to null is a code smell. Consider refactoring. | 218 |
| Assigning an Object to null is a code smell. Consider refactoring. | 219 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 48 - 249 |
| Parameter 'pwd' is not assigned and could be declared final | 84 |
| Local variable 'dbFile' could be declared final | 92 |
| Local variable 'f' could be declared final | 93 |
| Local variable 'url' could be declared final | 100 |
| Local variable 'userPass' could be declared final | 101 - 102 |
| New exception is thrown in catch block, original stack trace may be lost | 109 |
| New exception is thrown in catch block, original stack trace may be lost | 111 |
| Use block level rather than method level synchronization | 124 - 129 |
| Avoid using Literals in Conditional Statements | 126 |
| Use block level rather than method level synchronization | 138 - 145 |
| Parameter 'pwd' is not assigned and could be declared final | 138 |
| Avoid if (x != y) ..; else ..; | 140 - 143 |
| Avoid using Literals in Conditional Statements | 140 |
| Use block level rather than method level synchronization | 152 - 154 |
| Parameter 'tableName' is not assigned and could be declared final | 162 |
| Found 'DD'-anomaly for variable 'result' (lines '163'-'169'). | 163 - 169 |
| Local variable 'meta' could be declared final | 166 |
| Avoid using Literals in Conditional Statements | 167 |
| Ensure that resources like this ResultSet object are closed after use | 168 |
| Local variable 'res' could be declared final | 168 |
| Use block level rather than method level synchronization | 182 - 188 |
| Ensure that resources like this Statement object are closed after use | 196 |
| Found 'DD'-anomaly for variable 'result' (lines '196'-'198'). | 196 - 198 |
| Found 'DD'-anomaly for variable 'result' (lines '211'-'216'). | 211 - 216 |
| Local variable 'dbHome' could be declared final | 213 |
| Avoid using Literals in Conditional Statements | 214 |
| Local variable 'f' could be declared final | 215 |
| Found 'DD'-anomaly for variable 'result' (lines '227'-'230'). | 227 - 230 |
| Local variable 'userHome' could be declared final | 228 |
| Avoid using Literals in Conditional Statements | 229 |
| Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 45 - 184 |
| Parameter 'conn' is not assigned and could be declared final | 70 |
| Use block level rather than method level synchronization | 84 - 90 |
| Parameter 'conn' is not assigned and could be declared final | 84 |
| Avoid using Literals in Conditional Statements | 86 |
| Ensure that resources like this Statement object are closed after use | 99 |
| Local variable 'st' could be declared final | 99 |
| Parameter 'gpUri' is not assigned and could be declared final | 112 |
| Found 'DD'-anomaly for variable 'result' (lines '113'-'115'). | 113 - 115 |
| Found 'DD'-anomaly for variable 'result' (lines '126'-'128'). | 126 - 128 |
| Found 'DD'-anomaly for variable 'result' (lines '138'-'146'). | 138 - 146 |
| Ensure that resources like this Statement object are closed after use | 141 |
| Local variable 'st' could be declared final | 141 |
| Ensure that resources like this ResultSet object are closed after use | 142 |
| Local variable 'rs' could be declared final | 142 |
| Local variable 'val' could be declared final | 144 |
| Avoid using Literals in Conditional Statements | 145 |
| Parameter 'ms' is not assigned and could be declared final | 163 |
| Ensure that resources like this Statement object are closed after use | 165 |
| Local variable 'st' could be declared final | 165 |
| Assigning an Object to null is a code smell. Consider refactoring. | 179 |
| Assigning an Object to null is a code smell. Consider refactoring. | 180 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 44 - 225 |
| Parameter 'connector' is not assigned and could be declared final | 69 |
| Use block level rather than method level synchronization | 82 - 87 |
| Parameter 'jdbc' is not assigned and could be declared final | 82 |
| Avoid using Literals in Conditional Statements | 83 |
| Ensure that resources like this Statement object are closed after use | 96 |
| Local variable 'st' could be declared final | 96 |
| Parameter 'uuid' is not assigned and could be declared final | 111 |
| Found 'DD'-anomaly for variable 'result' (lines '112'-'124'). | 112 - 124 |
| Ensure that resources like this Statement object are closed after use | 115 |
| Local variable 'st' could be declared final | 115 |
| Ensure that resources like this ResultSet object are closed after use | 116 |
| Local variable 'rs' could be declared final | 116 - 117 |
| Local variable 'val' could be declared final | 119 |
| Local variable 'replyTo' could be declared final | 120 |
| Found 'DU'-anomaly for variable 'replyTo' (lines '120'-'139'). | 120 - 139 |
| Local variable 'proofSpecUri' could be declared final | 121 |
| Found 'DU'-anomaly for variable 'proofSpecUri' (lines '121'-'139'). | 121 - 139 |
| Local variable 'timestamp' could be declared final | 122 |
| Found 'DU'-anomaly for variable 'timestamp' (lines '122'-'139'). | 122 - 139 |
| Avoid using Literals in Conditional Statements | 123 |
| Local variable 'result' could be declared final | 145 |
| Ensure that resources like this Statement object are closed after use | 148 |
| Local variable 'st' could be declared final | 148 |
| Ensure that resources like this ResultSet object are closed after use | 149 |
| Local variable 'rs' could be declared final | 149 |
| Local variable 'specUri' could be declared final | 151 |
| Local variable 'proofVal' could be declared final | 152 |
| Local variable 'uuid' could be declared final | 153 |
| Found 'DU'-anomaly for variable 'uuid' (lines '153'-'170'). | 153 - 170 |
| Found 'DD'-anomaly for variable 'uuid' (lines '153'-'153'). | 153 |
| Local variable 'replyTo' could be declared final | 154 |
| Found 'DU'-anomaly for variable 'replyTo' (lines '154'-'170'). | 154 - 170 |
| Found 'DD'-anomaly for variable 'replyTo' (lines '154'-'154'). | 154 |
| Local variable 'timestamp' could be declared final | 155 |
| Found 'DU'-anomaly for variable 'timestamp' (lines '155'-'170'). | 155 - 170 |
| Found 'DD'-anomaly for variable 'timestamp' (lines '155'-'155'). | 155 |
| Local variable 'instance' could be declared final | 157 |
| Avoid instantiating new objects inside loops | 157 |
| Parameter 'replyTo' is not assigned and could be declared final | 176 |
| Parameter 'value' is not assigned and could be declared final | 176 |
| Parameter 'proofSpecUri' is not assigned and could be declared final | 176 |
| Found 'DD'-anomaly for variable 'result' (lines '177'-'190'). | 177 - 190 |
| Local variable 'instance' could be declared final | 180 - 181 |
| Ensure that resources like this Statement object are closed after use | 182 |
| Local variable 'st' could be declared final | 182 |
| Parameter 'uuid' is not assigned and could be declared final | 202 |
| Ensure that resources like this Statement object are closed after use | 204 |
| Local variable 'st' could be declared final | 204 |
| Assigning an Object to null is a code smell. Consider refactoring. | 220 |
| Assigning an Object to null is a code smell. Consider refactoring. | 221 |
| Violation | Line |
|---|---|
| Private field 'm_objBaseDir' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'baseDir' is not assigned and could be declared final | 52 |
| Found 'DD'-anomaly for variable 'result' (lines '65'-'67'). | 65 - 67 |
