The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Parameter 'v' is not assigned and could be declared final | 43 |
| Violation | Line |
|---|---|
| Parameter 'v' is not assigned and could be declared final | 81 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 70 |
| Parameter 'value' is not assigned and could be declared final | 92 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 93 |
| Parameter 'value' is not assigned and could be declared final | 117 |
| Parameter 'value' is not assigned and could be declared final | 141 |
| Parameter 'value' is not assigned and could be declared final | 165 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 77 |
| Parameter 'value' is not assigned and could be declared final | 101 |
| Parameter 'value' is not assigned and could be declared final | 125 |
| Parameter 'value' is not assigned and could be declared final | 149 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 73 |
| Parameter 'value' is not assigned and could be declared final | 97 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 73 |
| Parameter 'value' is not assigned and could be declared final | 97 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 84 |
| Parameter 'value' is not assigned and could be declared final | 108 |
| Parameter 'value' is not assigned and could be declared final | 132 |
| Parameter 'value' is not assigned and could be declared final | 156 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 85 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 133 |
| Parameter 'value' is not assigned and could be declared final | 157 |
| Parameter 'value' is not assigned and could be declared final | 181 |
| Parameter 'value' is not assigned and could be declared final | 205 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 34 - 39 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 67 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 69 |
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 29 - 231 |
| Document empty constructor | 36 - 37 |
| Avoid unnecessary constructors - the compiler will generate these for you | 36 - 37 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 69 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 77 |
| Parameter 'value' is not assigned and could be declared final | 101 |
| Parameter 'value' is not assigned and could be declared final | 125 |
| Parameter 'value' is not assigned and could be declared final | 149 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 74 |
| Parameter 'value' is not assigned and could be declared final | 98 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 34 - 39 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 57 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 73 |
| Parameter 'value' is not assigned and could be declared final | 97 |
| Parameter 'value' is not assigned and could be declared final | 121 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 74 |
| Parameter 'value' is not assigned and could be declared final | 98 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 34 - 39 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 57 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 68 |
| Parameter 'value' is not assigned and could be declared final | 92 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 73 |
| Parameter 'value' is not assigned and could be declared final | 97 |
| Parameter 'value' is not assigned and could be declared final | 121 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 69 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 57 |
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 67 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 31 - 49 |
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 54 |
| Parameter 'isPost' is not assigned and could be declared final | 54 |
| Parameter 'key' is not assigned and could be declared final | 83 |
| Found 'DD'-anomaly for variable 'result' (lines '84'-'88'). | 84 - 88 |
| Violation | Line |
|---|---|
| Parameter 'idemixId' is not assigned and could be declared final | 155 |
| Parameter 'certId' is not assigned and could be declared final | 155 |
| Parameter 'defVal' is not assigned and could be declared final | 156 |
| Parameter 'displayName' is not assigned and could be declared final | 156 |
| Parameter 'required' is not assigned and could be declared final | 156 |
| Parameter 'type' is not assigned and could be declared final | 156 |
| Parameter 'id' is not assigned and could be declared final | 217 |
| Found 'DD'-anomaly for variable 'result' (lines '218'-'222'). | 218 - 222 |
| Parameter 'id' is not assigned and could be declared final | 237 |
| Found 'DD'-anomaly for variable 'result' (lines '238'-'242'). | 238 - 242 |
| Parameter 'intVal' is not assigned and could be declared final | 257 |
| Found 'DD'-anomaly for variable 'result' (lines '258'-'264'). | 258 - 264 |
| Found 'DD'-anomaly for variable 'result' (lines '258'-'269'). | 258 - 269 |
| Avoid using Literals in Conditional Statements | 260 |
| Switch statements should have a default label | 261 - 271 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 261 - 271 |
| Avoid empty catch blocks | 265 - 266 |
| Parameter 'val' is not assigned and could be declared final | 284 |
| Found 'DD'-anomaly for variable 'result' (lines '285'-'291'). | 285 - 291 |
| Found 'DD'-anomaly for variable 'result' (lines '285'-'296'). | 285 - 296 |
| Avoid using Literals in Conditional Statements | 287 |
| Switch statements should have a default label | 288 - 298 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 288 - 298 |
| Avoid empty catch blocks | 292 - 293 |
| Parameter 'value' is not assigned and could be declared final | 311 |
| Found 'DD'-anomaly for variable 'result' (lines '312'-'317'). | 312 - 317 |
| Found 'DD'-anomaly for variable 'result' (lines '312'-'319'). | 312 - 319 |
| Found 'DD'-anomaly for variable 'result' (lines '312'-'321'). | 312 - 321 |
| Found 'DD'-anomaly for variable 'result' (lines '312'-'325'). | 312 - 325 |
| Found 'DD'-anomaly for variable 'result' (lines '312'-'327'). | 312 - 327 |
| Switch statements should have a default label | 314 - 329 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 314 - 329 |
| No need to check for null before an instanceof | 316 |
| No need to check for null before an instanceof | 318 |
| Violation | Line |
|---|---|
| Parameter 'idemixId' is not assigned and could be declared final | 77 |
| Parameter 'certId' is not assigned and could be declared final | 77 |
| Parameter 'displayName' is not assigned and could be declared final | 77 |
| Parameter 'required' is not assigned and could be declared final | 77 |
| Parameter 'defVal' is not assigned and could be declared final | 78 |
| Parameter 'type' is not assigned and could be declared final | 78 |
| Parameter 'id' is not assigned and could be declared final | 138 |
| Found 'DD'-anomaly for variable 'result' (lines '139'-'143'). | 139 - 143 |
| Parameter 'val' is not assigned and could be declared final | 157 |
| Found 'DD'-anomaly for variable 'result' (lines '158'-'164'). | 158 - 164 |
| Found 'DD'-anomaly for variable 'result' (lines '158'-'169'). | 158 - 169 |
| Avoid using Literals in Conditional Statements | 160 |
| Switch statements should have a default label | 161 - 171 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 161 - 171 |
| Avoid empty catch blocks | 165 - 166 |
| Parameter 'value' is not assigned and could be declared final | 183 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'189'). | 184 - 189 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'191'). | 184 - 191 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'193'). | 184 - 193 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'197'). | 184 - 197 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'199'). | 184 - 199 |
| Switch statements should have a default label | 186 - 201 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 186 - 201 |
| No need to check for null before an instanceof | 188 |
| No need to check for null before an instanceof | 190 |
| Parameter 'intVal' is not assigned and could be declared final | 212 |
| Found 'DD'-anomaly for variable 'result' (lines '213'-'219'). | 213 - 219 |
| Found 'DD'-anomaly for variable 'result' (lines '213'-'224'). | 213 - 224 |
| Avoid using Literals in Conditional Statements | 215 |
| Switch statements should have a default label | 216 - 226 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 216 - 226 |
| Avoid empty catch blocks | 220 - 221 |
| Violation | Line |
|---|---|
| Private field 'm_strHandlerId' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'm_numRCode' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'm_strRMsg' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'm_objData' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Private field 'm_objVeAttribs' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Parameter 'rmsg' is not assigned and could be declared final | 59 |
| Parameter 'rcode' is not assigned and could be declared final | 59 |
| Parameter 'handlerId' is not assigned and could be declared final | 60 |
| Parameter 'data' is not assigned and could be declared final | 60 |
| Parameter 'rmsg' is not assigned and could be declared final | 77 |
| Parameter 'rcode' is not assigned and could be declared final | 77 |
| Parameter 'handlerId' is not assigned and could be declared final | 78 |
| Parameter 'veData' is not assigned and could be declared final | 78 |
| Parameter 'data' is not assigned and could be declared final | 78 |
| Parameter 'value' is not assigned and could be declared final | 137 |
| Parameter 'attrib' is not assigned and could be declared final | 137 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 35 - 72 |
| Use block level rather than method level synchronization | 59 - 70 |
| Parameter 'code' is not assigned and could be declared final | 59 |
| Found 'DD'-anomaly for variable 'result' (lines '60'-'63'). | 60 - 63 |
| Avoid using Literals in Conditional Statements | 62 |
| Avoid using Literals in Conditional Statements | 65 |
| Violation | Line |
|---|---|
| The class 'ProofSpecParser' has a Cyclomatic Complexity of 2 (Highest = 20). | 59 - 676 |
| Private field 'm_objProofSpec' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Private field 'm_objCredStorage' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Private field 'm_objMissingCerts' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Private field 'm_objRequestedCerts' could be made final; it is only initialized in the declaration or constructor. | 75 |
| Private field 'm_objAttribDetail' could be made final; it is only initialized in the declaration or constructor. | 78 |
| Private field 'm_objIneqDetail' could be made final; it is only initialized in the declaration or constructor. | 81 |
| Private field 'm_objVencDetail' could be made final; it is only initialized in the declaration or constructor. | 84 |
| Private field 'm_strRequester' could be made final; it is only initialized in the declaration or constructor. | 87 |
| Private field 'm_objIdAttribMap' could be made final; it is only initialized in the declaration or constructor. | 90 |
| Private field 'm_objAttribValueMap' could be made final; it is only initialized in the declaration or constructor. | 93 |
| Private field 'm_objIdPkUriMap' could be made final; it is only initialized in the declaration or constructor. | 96 |
| Parameter 'spec' is not assigned and could be declared final | 111 |
| Parameter 'credentials' is not assigned and could be declared final | 111 |
| Parameter 'requester' is not assigned and could be declared final | 112 |
| The method parse() has an NPath complexity of 24373 | 130 - 218 |
| The method 'parse' has a Cyclomatic Complexity of 20. | 130 - 218 |
| Local variable 'preds' could be declared final | 131 |
| Avoid using Literals in Conditional Statements | 132 |
| Local variable 'pred' could be declared final | 135 |
| Local variable 'clp' could be declared final | 137 |
| Local variable 'struct' could be declared final | 138 |
| Local variable 'ipk' could be declared final | 139 |
| Local variable 'cred' could be declared final | 140 |
| Avoid instantiating new objects inside loops | 141 |
| Avoid using Literals in Conditional Statements | 142 |
| Avoid instantiating new objects inside loops | 144 |
| Local variable 'attribs' could be declared final | 146 - 147 |
| Local variable 'attiter' could be declared final | 148 |
| Local variable 'attrib' could be declared final | 150 |
| Local variable 'id' could be declared final | 151 |
| Deeply nested if..then statements are hard to read | 152 - 159 |
| Avoid using Literals in Conditional Statements | 152 |
| Local variable 'value' could be declared final | 153 |
| Avoid instantiating new objects inside loops | 154 - 155 |
| Local variable 'pred' could be declared final | 166 |
| Local variable 'iep' could be declared final | 168 |
| Local variable 'id1' could be declared final | 169 |
| Local variable 'id2' could be declared final | 170 |
| Local variable 'attr1' could be declared final | 171 |
| Found 'DD'-anomaly for variable 'attr2' (lines '172'-'178'). | 172 - 178 |
| Found 'DD'-anomaly for variable 'attr2' (lines '172'-'180'). | 172 - 180 |
| Found 'DD'-anomaly for variable 'attr2' (lines '172'-'183'). | 172 - 183 |
| Avoid if (x != y) ..; else ..; | 173 |
| Local variable 'strId1' could be declared final | 173 |
| Assigning an Object to null is a code smell. Consider refactoring. | 173 |
| Avoid if (x != y) ..; else ..; | 174 |
| Local variable 'strId2' could be declared final | 174 |
| Assigning an Object to null is a code smell. Consider refactoring. | 174 |
| Avoid instantiating new objects inside loops | 180 - 181 |
| Found 'DD'-anomaly for variable 'val1' (lines '185'-'187'). | 185 - 187 |
| Found 'DD'-anomaly for variable 'val2' (lines '188'-'190'). | 188 - 190 |
| Avoid instantiating new objects inside loops | 192 - 193 |
| Local variable 'pred' could be declared final | 198 |
| Local variable 'vencPred' could be declared final | 200 |
| Avoid instantiating new objects inside loops | 201 |
| Parameter 'id' is not assigned and could be declared final | 271 |
| Parameter 'idName' is not assigned and could be declared final | 281 |
| Parameter 'idName' is not assigned and could be declared final | 291 |
| Parameter 'attrName' is not assigned and could be declared final | 301 |
| Found 'DD'-anomaly for variable 'result' (lines '311'-'316'). | 311 - 316 |
| Avoid using Literals in Conditional Statements | 313 |
| Local variable 'idx' could be declared final | 314 |
| Avoid using Literals in Conditional Statements | 315 |
| Private field 'm_strAttribName' could be made final; it is only initialized in the declaration or constructor. | 328 |
| Private field 'm_strIdName' could be made final; it is only initialized in the declaration or constructor. | 331 |
| Private field 'm_bIsRevealed' could be made final; it is only initialized in the declaration or constructor. | 334 |
| Private field 'm_strValue' could be made final; it is only initialized in the declaration or constructor. | 337 |
| Parameter 'idName' is not assigned and could be declared final | 347 |
| Parameter 'attrName' is not assigned and could be declared final | 347 |
| Parameter 'isRevealed' is not assigned and could be declared final | 348 |
| Parameter 'value' is not assigned and could be declared final | 348 |
| Local variable 'result' could be declared final | 395 |
| Avoid using Literals in Conditional Statements | 398 |
| Private field 'm_strCertUri' could be made final; it is only initialized in the declaration or constructor. | 412 |
| Private field 'm_strIpkUri' could be made final; it is only initialized in the declaration or constructor. | 415 |
| Parameter 'certUri' is not assigned and could be declared final | 423 |
| Parameter 'ipkUri' is not assigned and could be declared final | 423 |
| Parameter 'cd' is not assigned and could be declared final | 452 |
| Private field 'm_objOp' could be made final; it is only initialized in the declaration or constructor. | 464 |
| Private field 'm_strAttr1' could be made final; it is only initialized in the declaration or constructor. | 467 |
| Private field 'm_strAttr2' could be made final; it is only initialized in the declaration or constructor. | 470 |
| Private field 'm_strId1' could be made final; it is only initialized in the declaration or constructor. | 473 |
| Private field 'm_strId2' could be made final; it is only initialized in the declaration or constructor. | 476 |
| Private field 'm_strVal1' could be made final; it is only initialized in the declaration or constructor. | 479 |
| Private field 'm_strVal2' could be made final; it is only initialized in the declaration or constructor. | 482 |
| Parameter 'id2' is not assigned and could be declared final | 495 |
| Parameter 'id1' is not assigned and could be declared final | 495 |
| Parameter 'attr2' is not assigned and could be declared final | 495 |
| Parameter 'attr1' is not assigned and could be declared final | 495 |
| Parameter 'op' is not assigned and could be declared final | 496 |
| Parameter 'val1' is not assigned and could be declared final | 496 |
| Parameter 'val2' is not assigned and could be declared final | 496 |
| Local variable 'result' could be declared final | 510 |
| Avoid using Literals in Conditional Statements | 516 |
| Avoid using Literals in Conditional Statements | 530 |
| Parameter 'op' is not assigned and could be declared final | 542 |
| Found 'DD'-anomaly for variable 'result' (lines '543'-'547'). | 543 - 547 |
| Found 'DD'-anomaly for variable 'result' (lines '543'-'550'). | 543 - 550 |
| Found 'DD'-anomaly for variable 'result' (lines '543'-'553'). | 543 - 553 |
| Found 'DD'-anomaly for variable 'result' (lines '543'-'556'). | 543 - 556 |
| Switch statements should have a default label | 545 - 559 |
| Private field 'm_strName' could be made final; it is only initialized in the declaration or constructor. | 571 |
| Private field 'm_strId' could be made final; it is only initialized in the declaration or constructor. | 574 |
| Private field 'm_objLabel' could be made final; it is only initialized in the declaration or constructor. | 577 |
| Avoid unused private fields such as 'm_objPk'. | 580 |
| Private field 'm_objPk' could be made final; it is only initialized in the declaration or constructor. | 580 |
| Private field 'm_objPkUri' could be made final; it is only initialized in the declaration or constructor. | 583 |
| Parameter 'id' is not assigned and could be declared final | 594 |
| Parameter 'pkUri' is not assigned and could be declared final | 594 |
| Parameter 'name' is not assigned and could be declared final | 594 |
| Parameter 'label' is not assigned and could be declared final | 594 |
| Parameter 'pk' is not assigned and could be declared final | 594 |
| Parameter 'proof' is not assigned and could be declared final | 645 |
| Parameter 'error' is not assigned and could be declared final | 663 |
| Violation | Line |
|---|---|
| The class 'RedirectContext' has a Cyclomatic Complexity of 3 (Highest = 11). | 46 - 431 |
| Private field 'm_objDest' could be made final; it is only initialized in the declaration or constructor. | 67 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 70 |
| Perhaps 'm_strData' could be replaced by a local variable. | 76 |
| Parameter 'destination' is not assigned and could be declared final | 83 |
| Parameter 'params' is not assigned and could be declared final | 97 |
| Parameter 'destination' is not assigned and could be declared final | 97 |
| Parameter 'type' is not assigned and could be declared final | 113 |
| Parameter 'destination' is not assigned and could be declared final | 113 |
| Parameter 'data' is not assigned and could be declared final | 114 |
| Parameter 'data' is not assigned and could be declared final | 125 |
| Parameter 'data' is not assigned and could be declared final | 140 |
| Parameter 'type' is not assigned and could be declared final | 140 |
| Parameter 'destination' is not assigned and could be declared final | 140 |
| Avoid using Literals in Conditional Statements | 144 |
| Parameter 'param' is not assigned and could be declared final | 182 |
| Found 'DD'-anomaly for variable 'result' (lines '190'-'191'). | 190 - 191 |
| Parameter 'srequest' is not assigned and could be declared final | 204 |
| Parameter 'sresponse' is not assigned and could be declared final | 205 |
| Switch statements should have a default label | 207 - 222 |
| Local variable 'redirect' could be declared final | 217 - 218 |
| Avoid using Literals in Conditional Statements | 219 |
| Parameter 'htmlData' is not assigned and could be declared final | 231 |
| The method 'parse' has a Cyclomatic Complexity of 11. | 244 - 283 |
| Parameter 'htmlData' is not assigned and could be declared final | 244 |
| Parameter 'request' is not assigned and could be declared final | 244 |
| Parameter 'type' is not assigned and could be declared final | 244 |
| Parameter 'destination' is not assigned and could be declared final | 244 |
| Found 'DD'-anomaly for variable 'result' (lines '245'-'250'). | 245 - 250 |
| Found 'DD'-anomaly for variable 'result' (lines '245'-'268'). | 245 - 268 |
| Found 'DD'-anomaly for variable 'result' (lines '245'-'275'). | 245 - 275 |
| Switch statements should have a default label | 247 - 280 |
| Found 'DD'-anomaly for variable 'data' (lines '255'-'265'). | 255 - 265 |
| Found 'DD'-anomaly for variable 'dest' (lines '256'-'260'). | 256 - 260 |
| Local variable 'strDest' could be declared final | 257 |
| Avoid using Literals in Conditional Statements | 258 |
| Avoid empty catch blocks | 262 - 263 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 266 |
| Local variable 'strData' could be declared final | 267 |
| Avoid using Literals in Conditional Statements | 270 |
| Local variable 'strData' could be declared final | 272 |
| Local variable 'dest' could be declared final | 273 |
| Found 'DU'-anomaly for variable 'dest' (lines '273'-'283'). | 273 - 283 |
| Avoid if (x != y) ..; else ..; | 274 - 277 |
| Avoid using Literals in Conditional Statements | 274 |
| Parameter 'elemLocalName' is not assigned and could be declared final | 293 |
| Parameter 'content' is not assigned and could be declared final | 294 |
| Parameter 'attribLocalName' is not assigned and could be declared final | 294 |
| Found 'DD'-anomaly for variable 'result' (lines '295'-'308'). | 295 - 308 |
| Avoid using Literals in Conditional Statements | 297 |
| Avoid using Literals in Conditional Statements | 299 |
| Avoid using Literals in Conditional Statements | 302 |
| Local variable 'end' could be declared final | 304 - 305 |
| The method 'getHtmlAttributes' has a Cyclomatic Complexity of 11. | 327 - 374 |
| Parameter 'elemLocalName' is not assigned and could be declared final | 328 |
| Parameter 'valueAttribName' is not assigned and could be declared final | 328 |
| Parameter 'keyAttribName' is not assigned and could be declared final | 328 |
| Parameter 'content' is not assigned and could be declared final | 329 |
| Local variable 'result' could be declared final | 330 |
| Avoid using Literals in Conditional Statements | 332 |
| Local variable 'attr1Beg' could be declared final | 335 - 336 |
| Local variable 'attr2Beg' could be declared final | 337 - 338 |
| Found 'DD'-anomaly for variable 'key' (lines '342'-'348'). | 342 - 348 |
| Found 'DU'-anomaly for variable 'key' (lines '342'-'374'). | 342 - 374 |
| Found 'DD'-anomaly for variable 'key' (lines '342'-'342'). | 342 |
| Found 'DD'-anomaly for variable 'value' (lines '343'-'359'). | 343 - 359 |
| Found 'DU'-anomaly for variable 'value' (lines '343'-'374'). | 343 - 374 |
| Found 'DD'-anomaly for variable 'value' (lines '343'-'343'). | 343 |
| Found 'DD'-anomaly for variable 'paramKey' (lines '350'-'352'). | 350 - 352 |
| Avoid empty catch blocks | 353 - 354 |
| Avoid using Literals in Conditional Statements | 355 |
| Parameter 'request' is not assigned and could be declared final | 382 |
| Found 'DD'-anomaly for variable 'result' (lines '383'-'397'). | 383 - 397 |
| Avoid using Literals in Conditional Statements | 385 |
| Found 'DD'-anomaly for variable 'type' (lines '386'-'388'). | 386 - 388 |
| Found 'DD'-anomaly for variable 'type' (lines '386'-'390'). | 386 - 390 |
| Avoid using Literals in Conditional Statements | 391 |
| Local variable 'dest' could be declared final | 396 |
| Parameter 'request' is not assigned and could be declared final | 414 |
| Local variable 'result' could be declared final | 415 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 415 |
| Local variable 'params' could be declared final | 416 |
| Local variable 'param' could be declared final | 418 |
| Found 'DD'-anomaly for variable 'hParam' (lines '419'-'421'). | 419 - 421 |
| Avoid empty catch blocks | 422 - 424 |
| Avoid using Literals in Conditional Statements | 425 |
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 70 - 653 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 70 - 653 |
| Parameter 'postParams' is not assigned and could be declared final | 100 |
| Parameter 'redirectTo' is not assigned and could be declared final | 101 |
| Found 'DD'-anomaly for variable 'result' (lines '102'-'124'). | 102 - 124 |
| Local variable 'html' could be declared final | 104 - 106 |
| Avoid using Literals in Conditional Statements | 108 |
| Local variable 'iter' could be declared final | 109 |
| Local variable 'key' could be declared final | 111 |
| Local variable 'val' could be declared final | 112 |
| Parameter 'str' is not assigned and could be declared final | 135 |
| Found 'DD'-anomaly for variable 'result' (lines '136'-'139'). | 136 - 139 |
| Local variable 'bytes' could be declared final | 138 |
| Parameter 'str' is not assigned and could be declared final | 146 |
| Found 'DD'-anomaly for variable 'result' (lines '147'-'150'). | 147 - 150 |
| Local variable 'bytes' could be declared final | 149 |
| Parameter 'str' is not assigned and could be declared final | 163 |
| Found 'DD'-anomaly for variable 'result' (lines '164'-'168'). | 164 - 168 |
| Avoid using Literals in Conditional Statements | 166 |
| Parameter 'bytes' is not assigned and could be declared final | 183 |
| Found 'DD'-anomaly for variable 'result' (lines '184'-'187'). | 184 - 187 |
| Avoid using Literals in Conditional Statements | 185 |
| Parameter 'b64Data' is not assigned and could be declared final | 201 |
| Found 'DD'-anomaly for variable 'result' (lines '202'-'204'). | 202 - 204 |
| Parameter 'b64Data' is not assigned and could be declared final | 217 |
| Found 'DD'-anomaly for variable 'result' (lines '218'-'221'). | 218 - 221 |
| Local variable 'bytes' could be declared final | 220 |
| Parameter 'inputStream' is not assigned and could be declared final | 235 |
| Found 'DD'-anomaly for variable 'result' (lines '236'-'247'). | 236 - 247 |
| Avoid using Literals in Conditional Statements | 238 |
| Local variable 'br' could be declared final | 240 - 241 |
| Found 'DD'-anomaly for variable 'line' (lines '242'-'244'). | 242 - 244 |
| Local variable 'content' could be declared final | 243 |
| Avoid assignments in operands | 244 |
| Found 'DU'-anomaly for variable 'line' (lines '244'-'254'). | 244 - 254 |
| Avoid empty catch blocks | 248 - 250 |
| Parameter 'str' is not assigned and could be declared final | 262 |
| Parameter 'file' is not assigned and could be declared final | 262 |
| Avoid using Literals in Conditional Statements | 264 |
| Local variable 'created' could be declared final | 270 |
| Local variable 'output' could be declared final | 272 |
| Parameter 'data' is not assigned and could be declared final | 305 |
| Found 'DD'-anomaly for variable 'result' (lines '306'-'314'). | 306 - 314 |
| Local variable 'm' could be declared final | 309 |
| Local variable 'writer' could be declared final | 310 |
| Parameter 'data' is not assigned and could be declared final | 328 |
| Found 'DD'-anomaly for variable 'result' (lines '329'-'343'). | 329 - 343 |
| Avoid using Literals in Conditional Statements | 331 |
| Local variable 'um' could be declared final | 333 |
| Avoid using Literals in Conditional Statements | 335 |
| Found 'DD'-anomaly for variable 'begidx' (lines '336'-'337'). | 336 - 337 |
| Local variable 'endidx' could be declared final | 338 |
| Local variable 'localName' could be declared final | 340 |
| Local variable 'cls' could be declared final | 341 |
| Local variable 'ssource' could be declared final | 342 |
| Parameter 'data' is not assigned and could be declared final | 359 |
| Parameter 'redirectTo' is not assigned and could be declared final | 359 |
| Found 'DD'-anomaly for variable 'result' (lines '360'-'370'). | 360 - 370 |
| Local variable 'params' could be declared final | 362 |
| Avoid using Literals in Conditional Statements | 363 |
| Avoid using Literals in Conditional Statements | 365 |
| Parameter 'data' is not assigned and could be declared final | 382 |
| Parameter 'pk' is not assigned and could be declared final | 382 |
| Found 'DD'-anomaly for variable 'result' (lines '383'-'388'). | 383 - 388 |
| Local variable 'strData' could be declared final | 386 |
| Avoid using Literals in Conditional Statements | 387 |
| Parameter 'nonce' is not assigned and could be declared final | 403 |
| Parameter 'msg' is not assigned and could be declared final | 403 |
| Parameter 'pk' is not assigned and could be declared final | 403 |
| Found 'DD'-anomaly for variable 'result' (lines '404'-'414'). | 404 - 414 |
| Local variable 'sp' could be declared final | 406 |
| Local variable 'context' could be declared final | 408 |
| Local variable 'messages' could be declared final | 411 |
| Use ArrayList instead of Vector | 414 |
| Parameter 'list' is not assigned and could be declared final | 425 |
| Local variable 'result' could be declared final | 426 |
| Avoid using Literals in Conditional Statements | 428 |
| Parameter 'list' is not assigned and could be declared final | 445 |
| Local variable 'result' could be declared final | 446 |
| Local variable 'itemStart' could be declared final | 447 |
| Found 'DU'-anomaly for variable 'itemStart' (lines '447'-'475'). | 447 - 475 |
| Local variable 'itemEnd' could be declared final | 448 |
| Found 'DU'-anomaly for variable 'itemEnd' (lines '448'-'475'). | 448 - 475 |
| Avoid using Literals in Conditional Statements | 450 |
| Found 'DD'-anomaly for variable 'end' (lines '453'-'455'). | 453 - 455 |
| Found 'DU'-anomaly for variable 'end' (lines '453'-'475'). | 453 - 475 |
| Avoid using Literals in Conditional Statements | 457 |
| Local variable 'vencStr' could be declared final | 458 |
| Found 'DD'-anomaly for variable 'enc' (lines '460'-'462'). | 460 - 462 |
| Avoid empty catch blocks | 463 |
| Avoid using Literals in Conditional Statements | 464 |
| Parameter 'map' is not assigned and could be declared final | 483 |
| Local variable 'result' could be declared final | 484 |
| Local variable 'itemStart' could be declared final | 485 |
| Found 'DU'-anomaly for variable 'itemStart' (lines '485'-'503'). | 485 - 503 |
| Local variable 'itemEnd' could be declared final | 486 |
| Found 'DU'-anomaly for variable 'itemEnd' (lines '486'-'503'). | 486 - 503 |
| Local variable 'valueStart' could be declared final | 487 |
| Found 'DU'-anomaly for variable 'valueStart' (lines '487'-'503'). | 487 - 503 |
| Local variable 'valueEnd' could be declared final | 488 |
| Found 'DU'-anomaly for variable 'valueEnd' (lines '488'-'503'). | 488 - 503 |
| Local variable 'nameStart' could be declared final | 489 |
| Found 'DU'-anomaly for variable 'nameStart' (lines '489'-'503'). | 489 - 503 |
| Local variable 'nameEnd' could be declared final | 490 |
| Found 'DU'-anomaly for variable 'nameEnd' (lines '490'-'503'). | 490 - 503 |
| Avoid using Literals in Conditional Statements | 493 |
| Local variable 'iter' could be declared final | 494 |
| Local variable 'key' could be declared final | 496 |
| Local variable 'value' could be declared final | 497 |
| Parameter 'list' is not assigned and could be declared final | 511 |
| Local variable 'result' could be declared final | 512 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 512 |
| Local variable 'itemStart' could be declared final | 513 |
| Found 'DU'-anomaly for variable 'itemStart' (lines '513'-'536'). | 513 - 536 |
| Local variable 'itemEnd' could be declared final | 514 |
| Found 'DU'-anomaly for variable 'itemEnd' (lines '514'-'536'). | 514 - 536 |
| Avoid using Literals in Conditional Statements | 516 |
| Found 'DD'-anomaly for variable 'end' (lines '518'-'520'). | 518 - 520 |
| Found 'DU'-anomaly for variable 'end' (lines '518'-'536'). | 518 - 536 |
| Avoid using Literals in Conditional Statements | 521 |
| Local variable 'name' could be declared final | 522 |
| Local variable 'value' could be declared final | 523 |
| Avoid instantiating new objects inside loops | 526 |
| Parameter 'item' is not assigned and could be declared final | 545 |
| Parameter 'delim' is not assigned and could be declared final | 545 |
| Found 'DD'-anomaly for variable 'result' (lines '546'-'557'). | 546 - 557 |
| Local variable 'childStart' could be declared final | 548 |
| Local variable 'childEnd' could be declared final | 549 |
| Found 'DU'-anomaly for variable 'childEnd' (lines '549'-'560'). | 549 - 560 |
| Local variable 'beg' could be declared final | 551 |
| Found 'DD'-anomaly for variable 'end' (lines '552'-'554'). | 552 - 554 |
| Avoid using Literals in Conditional Statements | 553 |
| Parameter 'response' is not assigned and could be declared final | 567 |
| Parameter 'response' is not assigned and could be declared final | 576 |
| Parameter 'response' is not assigned and could be declared final | 587 |
| Parameter 'error' is not assigned and could be declared final | 587 |
| Avoid using Literals in Conditional Statements | 588 |
| Found 'DD'-anomaly for variable 'status' (lines '589'-'591'). | 589 - 591 |
| Found 'DD'-anomaly for variable 'status' (lines '589'-'594'). | 589 - 594 |
| Avoid using Literals in Conditional Statements | 590 |
| Parameter 'response' is not assigned and could be declared final | 607 |
| Parameter 'request' is not assigned and could be declared final | 607 |
| Parameter 'response' is not assigned and could be declared final | 619 |
| Parameter 'request' is not assigned and could be declared final | 619 |
| Parameter 'successCritical' is not assigned and could be declared final | 619 |
| Avoid if (x != y) ..; else ..; | 620 - 640 |
| Avoid using Literals in Conditional Statements | 620 |
| Local variable 'status' could be declared final | 621 |
| Avoid using Literals in Conditional Statements | 624 |
| Avoid using Literals in Conditional Statements | 628 |
| Parameter 'request' is not assigned and could be declared final | 649 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 39 |
| Parameter 'cause' is not assigned and could be declared final | 39 |
| Parameter 'message' is not assigned and could be declared final | 49 |
| Parameter 'cause' is not assigned and could be declared final | 59 |
| Violation | Line |
|---|---|
| Parameter 'uuid' is not assigned and could be declared final | 56 |
| An empty method in an abstract class should be abstract instead | 79 - 81 |
| Parameter 'time' is not assigned and could be declared final | 97 |
| Parameter 'o' is not assigned and could be declared final | 111 |
| Found 'DD'-anomaly for variable 'result' (lines '112'-'115'). | 112 - 115 |
| Parameter 'category' is not assigned and could be declared final | 126 |
| Found 'DD'-anomaly for variable 'result' (lines '127'-'129'). | 127 - 129 |
| Violation | Line |
|---|---|
| Private field 'm_strCredName' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'm_strIpkName' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Private field 'm_strValue' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Parameter 'credUri' is not assigned and could be declared final | 64 |
| Parameter 'ipkUri' is not assigned and could be declared final | 64 |
| Parameter 'value' is not assigned and could be declared final | 64 |
| It is a good practice to call super() in a constructor | 64 - 69 |
| Parameter 'val' is not assigned and could be declared final | 81 |
| Parameter 'credUri' is not assigned and could be declared final | 81 |
| Parameter 'ipkUri' is not assigned and could be declared final | 81 |
| It is a good practice to call super() in a constructor | 81 - 86 |
| Avoid using Literals in Conditional Statements | 121 |
| Found 'DD'-anomaly for variable 'result' (lines '152'-'155'). | 152 - 155 |
| Local variable 'epoch' could be declared final | 153 |
| Avoid using Literals in Conditional Statements | 154 |
| Local variable 'result' could be declared final | 165 |
| Local variable 'attribs' could be declared final | 167 |
| Local variable 'result' could be declared final | 182 |
| Local variable 'attribs' could be declared final | 184 |
| Switch statements should have a default label | 186 - 194 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 186 - 194 |
| Avoid instantiating new objects inside loops | 188 - 189 |
| Parameter 'attrib' is not assigned and could be declared final | 208 |
| Found 'DD'-anomaly for variable 'result' (lines '209'-'215'). | 209 - 215 |
| Found 'DD'-anomaly for variable 'result' (lines '209'-'218'). | 209 - 218 |
| Local variable 'attribute' could be declared final | 211 |
| Avoid using Literals in Conditional Statements | 212 |
| Switch statements should have a default label | 213 - 220 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 213 - 220 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 39 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 52 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 69 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 81 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 62 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 65 |
| Violation | Line |
|---|---|
| No need to import a type that lives in the same package | 28 |
| No need to import a type that lives in the same package | 29 |
| No need to import a type that lives in the same package | 30 |
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 65 |
| Avoid modifiers which are implied by the context | 70 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 38 |
| Avoid modifiers which are implied by the context | 43 |
| Violation | Line |
|---|---|
| Private field 'm_strSpec' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'm_strValue' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Private field 'm_strReplyTo' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Parameter 'replyTo' is not assigned and could be declared final | 62 |
| Parameter 'value' is not assigned and could be declared final | 62 |
| Parameter 'proofSpecUri' is not assigned and could be declared final | 62 |
| It is a good practice to call super() in a constructor | 62 - 67 |
| Parameter 'replyTo' is not assigned and could be declared final | 76 |
| Parameter 'proofVal' is not assigned and could be declared final | 76 |
| Parameter 'specUri' is not assigned and could be declared final | 76 |
| It is a good practice to call super() in a constructor | 76 - 81 |
| Avoid using Literals in Conditional Statements | 107 |
| Violation | Line |
|---|---|
| Private field 'm_strCredUri' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'm_strIpkUri' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Parameter 'credUri' is not assigned and could be declared final | 45 |
| Parameter 'ipkUri' is not assigned and could be declared final | 45 |
| Violation | Line |
|---|---|
| Private field 'm_numError' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Parameter 'errorCode' is not assigned and could be declared final | 57 |
| It is a good practice to call super() in a constructor | 57 - 59 |
