The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Parameter 'optional' is not assigned and could be declared final | 96 |
| Parameter 'type' is not assigned and could be declared final | 96 |
| Parameter 'cfg' is not assigned and could be declared final | 128 |
| Avoid using Literals in Conditional Statements | 134 |
| Avoid empty catch blocks | 137 - 138 |
| Parameter 'cfg' is not assigned and could be declared final | 157 |
| Parameter 'cfg' is not assigned and could be declared final | 179 |
| Avoid using Literals in Conditional Statements | 185 |
| Avoid empty catch blocks | 189 - 190 |
| Parameter 'cfg' is not assigned and could be declared final | 209 |
| Local variable 'result' could be declared final | 210 |
| Parameter 'cfg' is not assigned and could be declared final | 225 |
| Local variable 'params' could be declared final | 229 |
| Local variable 'param' could be declared final | 231 |
| Local variable 'map' could be declared final | 234 |
| Avoid using Literals in Conditional Statements | 235 |
| Deeply nested if..then statements are hard to read | 236 - 237 |
| Avoid using Literals in Conditional Statements | 236 |
| Avoid instantiating new objects inside loops | 237 |
| Parameter 'param' is not assigned and could be declared final | 260 |
| Parameter 'cfg' is not assigned and could be declared final | 260 |
| Local variable 'keyval' could be declared final | 268 |
| Prefer StringBuffer over += for concatenating strings | 272 |
| Assigning an Object to null is a code smell. Consider refactoring. | 279 |
| Assigning an Object to null is a code smell. Consider refactoring. | 280 |
| Private field 'm_objId' could be made final; it is only initialized in the declaration or constructor. | 299 |
| Private field 'm_objDest' could be made final; it is only initialized in the declaration or constructor. | 302 |
| Parameter 'id' is not assigned and could be declared final | 312 |
| Parameter 'dest' is not assigned and could be declared final | 312 |
| Violation | Line |
|---|---|
| Private field 'm_objAttribList' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'm_objResultHandler' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Parameter 'attributes' is not assigned and could be declared final | 48 |
| Parameter 'resultHandler' is not assigned and could be declared final | 48 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 - 54 |
| Avoid modifiers which are implied by the context | 65 - 66 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 - 56 |
| Avoid modifiers which are implied by the context | 67 - 68 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 69 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 67 - 68 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 89 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 101 |
| Avoid modifiers which are implied by the context | 108 |
| Avoid modifiers which are implied by the context | 115 |
| Avoid modifiers which are implied by the context | 122 |
| Avoid modifiers which are implied by the context | 129 |
| Avoid modifiers which are implied by the context | 137 |
| Avoid modifiers which are implied by the context | 145 |
| Avoid modifiers which are implied by the context | 153 |
| Avoid modifiers which are implied by the context | 160 |
| Avoid modifiers which are implied by the context | 167 |
| Avoid modifiers which are implied by the context | 174 |
| Avoid modifiers which are implied by the context | 181 |
| Avoid modifiers which are implied by the context | 188 |
| Avoid modifiers which are implied by the context | 195 |
| Avoid modifiers which are implied by the context | 202 |
| Avoid modifiers which are implied by the context | 209 |
| Avoid modifiers which are implied by the context | 218 |
| Avoid modifiers which are implied by the context | 225 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 39 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 63 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 71 |
| Avoid modifiers which are implied by the context | 78 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 34 |
| Avoid modifiers which are implied by the context | 37 |
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 84 |
| Avoid modifiers which are implied by the context | 93 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 66 |
| Avoid modifiers which are implied by the context | 75 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 39 |
| Avoid modifiers which are implied by the context | 46 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 42 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 59 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 40 - 187 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field 'm_objTempStorage' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Private field 'm_objIssuerRepo' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Private field 'm_objTimeRepo' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Parameter 'tempStorage' is not assigned and could be declared final | 76 |
| Parameter 'cfg' is not assigned and could be declared final | 76 |
| Parameter 'storage' is not assigned and could be declared final | 76 |
| Use block level rather than method level synchronization | 95 - 100 |
| Parameter 'tempStorage' is not assigned and could be declared final | 95 |
| Parameter 'config' is not assigned and could be declared final | 95 |
| Parameter 'storage' is not assigned and could be declared final | 95 |
| Avoid using Literals in Conditional Statements | 96 |
| Parameter 'handler' is not assigned and could be declared final | 114 |
| Found 'DD'-anomaly for variable 'result' (lines '115'-'117'). | 115 - 117 |
| Local variable 'id' could be declared final | 118 |
| Parameter 'uuid' is not assigned and could be declared final | 131 |
| Found 'DD'-anomaly for variable 'result' (lines '132'-'134'). | 132 - 134 |
| Avoid if (x != y) ..; else ..; | 135 - 140 |
| Avoid using Literals in Conditional Statements | 135 |
| Local variable 'currentTime' could be declared final | 150 |
| Found 'DU'-anomaly for variable 'currentTime' (lines '150'-'167'). | 150 - 167 |
| Local variable 'iter' could be declared final | 152 |
| Local variable 'candidates' could be declared final | 153 |
| Local variable 'key' could be declared final | 155 |
| Local variable 'val' could be declared final | 156 |
| Parameter 'uuid' is not assigned and could be declared final | 173 |
| Found 'DD'-anomaly for variable 'result' (lines '174'-'176'). | 174 - 176 |
| Avoid if (x != y) ..; else ..; | 177 - 181 |
| Avoid using Literals in Conditional Statements | 177 |
| Violation | Line |
|---|---|
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Private field 'm_strUuid' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Private field 'm_objSpecHandler' could be made final; it is only initialized in the declaration or constructor. | 78 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 81 |
| Private field 'm_objTempStorage' could be made final; it is only initialized in the declaration or constructor. | 96 |
| Avoid unused private fields such as 'm_objEidData'. | 99 |
| Parameter 'cfg' is not assigned and could be declared final | 109 |
| Parameter 'handler' is not assigned and could be declared final | 109 |
| Parameter 'tempStorage' is not assigned and could be declared final | 110 |
| Parameter 'storage' is not assigned and could be declared final | 110 |
| Parameter 'msg' is not assigned and could be declared final | 170 |
| Found 'DD'-anomaly for variable 'result' (lines '173'-'184'). | 173 - 184 |
| Avoid using Literals in Conditional Statements | 175 |
| Local variable 'outMsg' could be declared final | 177 |
| Found 'DD'-anomaly for variable 'strMsg' (lines '181'-'182'). | 181 - 182 |
| Parameter 'msg' is not assigned and could be declared final | 226 |
| Local variable 'returnString' could be declared final | 229 |
| Parameter 'str' is not assigned and could be declared final | 240 |
| Found 'DD'-anomaly for variable 'result' (lines '243'-'245'). | 243 - 245 |
| Found 'DD'-anomaly for variable 'result' (lines '281'-'297'). | 281 - 297 |
| Local variable 'v' could be declared final | 292 |
| Parameter 'attributes' is not assigned and could be declared final | 328 |
| Found 'DD'-anomaly for variable 'result' (lines '331'-'346'). | 331 - 346 |
| Found 'DD'-anomaly for variable 'result' (lines '331'-'350'). | 331 - 350 |
| Avoid using Literals in Conditional Statements | 332 |
| Local variable 'iter' could be declared final | 333 |
| Found 'DU'-anomaly for variable 'iter' (lines '333'-'357'). | 333 - 357 |
| Avoid if (x != y) ..; else ..; | 334 - 352 |
| Local variable 'encList' could be declared final | 336 |
| Local variable 'key' could be declared final | 338 |
| Local variable 'value' could be declared final | 339 |
| Local variable 'random' could be declared final | 340 |
| Local variable 'veo' could be declared final | 341 - 343 |
| Avoid instantiating new objects inside loops | 341 - 343 |
| Parameter 'data' is not assigned and could be declared final | 367 |
| Found 'DD'-anomaly for variable 'result' (lines '370'-'374'). | 370 - 374 |
| Avoid using Literals in Conditional Statements | 372 |
| Parameter 'specId' is not assigned and could be declared final | 394 |
| Parameter 'cfg' is not assigned and could be declared final | 395 |
| Local variable 'result' could be declared final | 398 |
| Parameter 'vepkUri' is not assigned and could be declared final | 417 |
| Parameter 'pk' is not assigned and could be declared final | 417 |
| Avoid if (x != y) ..; else ..; | 420 - 428 |
| Local variable 'file' could be declared final | 421 |
| Parameter 'eidData' is not assigned and could be declared final | 438 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 155 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Parameter 'storage' is not assigned and could be declared final | 63 |
| Use block level rather than method level synchronization | 73 - 75 |
| Use block level rather than method level synchronization | 84 - 87 |
| Parameter 'storage' is not assigned and could be declared final | 84 |
| Use block level rather than method level synchronization | 94 - 96 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 38 - 221 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'cfg' is not assigned and could be declared final | 70 |
| Parameter 'secStorage' is not assigned and could be declared final | 86 |
| Parameter 'eidRepo' is not assigned and could be declared final | 86 |
| Parameter 'verifierRepo' is not assigned and could be declared final | 86 |
| Parameter 'specRepo' is not assigned and could be declared final | 86 |
| Parameter 'issuerRepo' is not assigned and could be declared final | 86 |
| Parameter 'tmpRepo' is not assigned and could be declared final | 86 |
| Parameter 'cfg' is not assigned and could be declared final | 86 |
| Use block level rather than method level synchronization | 101 - 103 |
| Use block level rather than method level synchronization | 112 - 115 |
| Parameter 'cfg' is not assigned and could be declared final | 112 |
| Use block level rather than method level synchronization | 122 - 124 |
| Use block level rather than method level synchronization | 202 - 205 |
| Parameter 'secStorage' is not assigned and could be declared final | 202 |
| Parameter 'eidRepo' is not assigned and could be declared final | 202 |
| Parameter 'verifierRepo' is not assigned and could be declared final | 202 |
| Parameter 'specRepo' is not assigned and could be declared final | 202 |
| Parameter 'issuerRepo' is not assigned and could be declared final | 202 |
| Parameter 'tmpRepo' is not assigned and could be declared final | 202 |
| Parameter 'cfg' is not assigned and could be declared final | 202 |
| Violation | Line |
|---|---|
| Private field 'm_objKey' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'm_strVal' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'value' is not assigned and could be declared final | 47 |
| Parameter 'key' is not assigned and could be declared final | 47 |
| Violation | Line |
|---|---|
| Parameter 't' is not assigned and could be declared final | 38 |
| Violation | Line |
|---|---|
| Private field 'm_objSrvHandler' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Parameter 'handler' is not assigned and could be declared final | 67 |
| Parameter 'srequest' is not assigned and could be declared final | 75 |
| Parameter 'request' is not assigned and could be declared final | 76 |
| Parameter 'sresponse' is not assigned and could be declared final | 76 |
| Local variable 'handler' could be declared final | 80 |
| Local variable 'attribs' could be declared final | 81 |
| Avoid if (x != y) ..; else ..; | 82 - 92 |
| Local variable 'handlerId' could be declared final | 83 |
| Local variable 'wrapper' could be declared final | 85 |
| Parameter 'srequest' is not assigned and could be declared final | 108 |
| Parameter 'sresponse' is not assigned and could be declared final | 109 |
| Local variable 'result' could be declared final | 112 |
| Local variable 'handlerId' could be declared final | 113 |
| Avoid if (x != y) ..; else ..; | 114 - 138 |
| Avoid using Literals in Conditional Statements | 114 |
| Local variable 'handler' could be declared final | 115 |
| Avoid if (x != y) ..; else ..; | 116 - 135 |
| Avoid using Literals in Conditional Statements | 116 |
| Local variable 'idata' could be declared final | 117 |
| Avoid if (x != y) ..; else ..; | 118 - 132 |
| Avoid using Literals in Conditional Statements | 118 |
| Local variable 'redCtx' could be declared final | 121 |
| Violation | Line |
|---|---|
| The class 'IssuanceService' has a Cyclomatic Complexity of 6 (Highest = 14). | 67 - 311 |
| Private field 'm_objEidAttrServ' could be made final; it is only initialized in the declaration or constructor. | 74 |
| Private field 'm_objIssuerRepo' could be made final; it is only initialized in the declaration or constructor. | 77 |
| Private field 'm_objSpecHandlerRepo' could be made final; it is only initialized in the declaration or constructor. | 80 |
| Private field 'm_objIssuerCfg' could be made final; it is only initialized in the declaration or constructor. | 83 |
| Avoid unused private fields such as 'm_objStorage'. | 86 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 86 |
| Perhaps 'm_objStorage' could be replaced by a local variable. | 86 |
| Parameter 'wrapper' is not assigned and could be declared final | 94 |
| Parameter 'eidAttrSrv' is not assigned and could be declared final | 95 |
| Parameter 'uuid' is not assigned and could be declared final | 110 |
| Parameter 'msg' is not assigned and could be declared final | 110 |
| Local variable 'service' could be declared final | 115 |
| Avoid using Literals in Conditional Statements | 116 |
| Local variable 'isresp' could be declared final | 117 |
| Avoid using Literals in Conditional Statements | 118 |
| The method 'processDataRequest' has a Cyclomatic Complexity of 14. | 132 - 207 |
| Parameter 'srequest' is not assigned and could be declared final | 132 |
| Parameter 'irequest' is not assigned and could be declared final | 133 |
| Parameter 'sresponse' is not assigned and could be declared final | 133 |
| Avoid using Literals in Conditional Statements | 140 |
| Local variable 'specId' could be declared final | 141 |
| Local variable 'specHandler' could be declared final | 142 - 143 |
| Local variable 'innerType' could be declared final | 144 |
| Found 'DD'-anomaly for variable 'vepkUri' (lines '145'-'148'). | 145 - 148 |
| Found 'DU'-anomaly for variable 'vepkUri' (lines '145'-'207'). | 145 - 207 |
| Found 'DD'-anomaly for variable 'vepData' (lines '146'-'150'). | 146 - 150 |
| Found 'DU'-anomaly for variable 'vepData' (lines '146'-'207'). | 146 - 207 |
| Avoid using Literals in Conditional Statements | 147 |
| Found 'DU'-anomaly for variable 'vepkUri' (lines '148'-'207'). | 148 - 207 |
| Deeply nested if..then statements are hard to read | 149 - 151 |
| Avoid using Literals in Conditional Statements | 149 |
| Found 'DU'-anomaly for variable 'vepData' (lines '150'-'207'). | 150 - 207 |
| Avoid if (x != y) ..; else ..; | 153 - 185 |
| Avoid using Literals in Conditional Statements | 153 |
| Local variable 'resultHandler' could be declared final | 155 - 156 |
| Avoid if (x != y) ..; else ..; | 157 - 171 |
| Avoid using Literals in Conditional Statements | 157 |
| Local variable 'attribs' could be declared final | 159 - 160 |
| Local variable 'eidrequest' could be declared final | 161 - 162 |
| Assigning an Object to null is a code smell. Consider refactoring. | 166 |
| Local variable 'service' could be declared final | 173 - 174 |
| Local variable 'resp' could be declared final | 177 |
| Avoid using Literals in Conditional Statements | 178 |
| Avoid using Literals in Conditional Statements | 195 |
| Local variable 'ctx' could be declared final | 198 |
| Parameter 'specId' is not assigned and could be declared final | 213 |
| Local variable 'ireq' could be declared final | 218 - 219 |
| Avoid using Literals in Conditional Statements | 220 |
| Parameter 'request' is not assigned and could be declared final | 232 |
| Avoid using Literals in Conditional Statements | 238 |
| Local variable 'specId' could be declared final | 239 |
| Local variable 'specHandler' could be declared final | 240 |
| Local variable 'innerType' could be declared final | 241 |
| Found 'DD'-anomaly for variable 'vepkUri' (lines '242'-'245'). | 242 - 245 |
| Found 'DU'-anomaly for variable 'vepkUri' (lines '242'-'270'). | 242 - 270 |
| Found 'DD'-anomaly for variable 'vepData' (lines '243'-'247'). | 243 - 247 |
| Found 'DU'-anomaly for variable 'vepData' (lines '243'-'270'). | 243 - 270 |
| Avoid using Literals in Conditional Statements | 244 |
| Found 'DU'-anomaly for variable 'vepkUri' (lines '245'-'270'). | 245 - 270 |
| Avoid using Literals in Conditional Statements | 246 |
| Found 'DU'-anomaly for variable 'vepData' (lines '247'-'270'). | 247 - 270 |
| Avoid if (x != y) ..; else ..; | 250 - 259 |
| Avoid using Literals in Conditional Statements | 250 |
| Local variable 'service' could be declared final | 251 |
| Local variable 'idresp' could be declared final | 254 |
| Avoid using Literals in Conditional Statements | 255 |
| Parameter 'request' is not assigned and could be declared final | 276 |
| Local variable 'uuid' could be declared final | 282 |
| Avoid if (x != y) ..; else ..; | 283 - 299 |
| Avoid using Literals in Conditional Statements | 283 |
| Local variable 'strMsg' could be declared final | 284 |
| Avoid if (x != y) ..; else ..; | 285 - 295 |
| Avoid using Literals in Conditional Statements | 285 |
| Local variable 'msg' could be declared final | 286 |
| Avoid if (x != y) ..; else ..; | 287 - 292 |
| Avoid using Literals in Conditional Statements | 287 |
| Violation | Line |
|---|---|
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 71 |
| Private field 'm_objEidAttrSrv' could be made final; it is only initialized in the declaration or constructor. | 74 |
| Private field 'm_objVerifierRepo' could be made final; it is only initialized in the declaration or constructor. | 77 |
| Parameter 'eidAttribService' is not assigned and could be declared final | 85 |
| Parameter 'storage' is not assigned and could be declared final | 85 |
| Parameter 'ownerId' is not assigned and could be declared final | 95 |
| Found 'DD'-anomaly for variable 'result' (lines '98'-'101'). | 98 - 101 |
| Avoid using Literals in Conditional Statements | 99 |
| Parameter 'uuid' is not assigned and could be declared final | 112 |
| Found 'DD'-anomaly for variable 'result' (lines '115'-'118'). | 115 - 118 |
| Avoid using Literals in Conditional Statements | 116 |
| Parameter 'srequest' is not assigned and could be declared final | 129 |
| Parameter 'sresponse' is not assigned and could be declared final | 130 |
| Local variable 'resultHandler' could be declared final | 134 |
| Avoid if (x != y) ..; else ..; | 135 - 142 |
| Avoid using Literals in Conditional Statements | 135 |
| Local variable 'attribs' could be declared final | 136 |
| Local variable 'request' could be declared final | 138 |
| Avoid empty if statements | 140 - 142 |
| Local variable 'revokeId' could be declared final | 164 |
| Local variable 'service' could be declared final | 165 |
| Local variable 'rreq' could be declared final | 167 |
| Avoid using Literals in Conditional Statements | 168 |
| Parameter 'nonce' is not assigned and could be declared final | 185 |
| Parameter 'pop' is not assigned and could be declared final | 185 |
| Local variable 'service' could be declared final | 190 |
| Avoid if (x != y) ..; else ..; | 191 - 214 |
| Avoid using Literals in Conditional Statements | 191 |
| Local variable 'vres' could be declared final | 192 |
| Local variable 'veName' could be declared final | 195 |
| Local variable 'enc' could be declared final | 196 |
| Local variable 'value' could be declared final | 197 |
| Avoid if (x != y) ..; else ..; | 198 - 206 |
| Avoid using Literals in Conditional Statements | 198 |
| Local variable 'certId' could be declared final | 199 |
| Local variable 'done' could be declared final | 200 |
| Parameter 'response' is not assigned and could be declared final | 227 |
| Avoid using Literals in Conditional Statements | 233 |
| Local variable 'dataStr' could be declared final | 234 |
| Avoid if (x != y) ..; else ..; | 235 - 254 |
| Avoid using Literals in Conditional Statements | 235 |
| Local variable 'p' could be declared final | 236 |
| Local variable 'nonce' could be declared final | 237 |
| Avoid if (x != y) ..; else ..; | 238 - 250 |
| Local variable 'rres' could be declared final | 239 |
| Avoid using Literals in Conditional Statements | 240 |
| Avoid using Literals in Conditional Statements | 246 |
| Violation | Line |
|---|---|
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Parameter 'storage' is not assigned and could be declared final | 62 |
| Parameter 'enc' is not assigned and could be declared final | 73 |
| Local variable 'vesk' could be declared final | 76 |
| Local variable 'certId' could be declared final | 78 |
| Local variable 'returnint' could be declared final | 80 - 81 |
| Parameter 'request' is not assigned and could be declared final | 90 |
| Avoid using Literals in Conditional Statements | 97 |
| Found 'DD'-anomaly for variable 'replyTo' (lines '98'-'100'). | 98 - 100 |
| Local variable 'dataStr' could be declared final | 106 |
| Local variable 've' could be declared final | 107 |
| Local variable 'status' could be declared final | 108 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 38 - 84 |
| Private field 'm_objHandlerRepo' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Use block level rather than method level synchronization | 58 - 62 |
| Avoid using Literals in Conditional Statements | 59 |
| Use block level rather than method level synchronization | 68 - 74 |
| Parameter 'handler' is not assigned and could be declared final | 68 |
| Local variable 'result' could be declared final | 69 |
| Use block level rather than method level synchronization | 80 - 82 |
| Parameter 'uuid' is not assigned and could be declared final | 80 |
| Violation | Line |
|---|---|
| Private field 'm_objIRepo' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Perhaps 'm_objIRepo' could be replaced by a local variable. | 49 |
| Private field 'm_objService' could be made final; it is only initialized in the declaration or constructor. | 52 |
| Parameter 'vepkUri' is not assigned and could be declared final | 62 |
| Parameter 'issuerRepo' is not assigned and could be declared final | 62 |
| Parameter 'shandler' is not assigned and could be declared final | 62 |
| Parameter 'pkContent' is not assigned and could be declared final | 62 |
| Parameter 'resultData' is not assigned and could be declared final | 72 |
| Local variable 'returnIssueDataResponseType' could be declared final | 76 - 77 |
| Violation | Line |
|---|---|
| Private field 'm_objService' could be made final; it is only initialized in the declaration or constructor. | 52 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Parameter 'revocationService' is not assigned and could be declared final | 63 |
| Parameter 'config' is not assigned and could be declared final | 64 |
| Parameter 'resultData' is not assigned and could be declared final | 73 |
| Local variable 'result' could be declared final | 76 |
| Avoid if (x != y) ..; else ..; | 78 - 89 |
| Avoid using Literals in Conditional Statements | 78 |
| Local variable 'data' could be declared final | 79 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 79 |
| Local variable 'ri' could be declared final | 80 |
| Avoid if (x != y) ..; else ..; | 81 - 86 |
| Avoid using Literals in Conditional Statements | 81 |
| Violation | Line |
|---|---|
| Private field 'm_objEidAttrSrv' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Parameter 'eidAttrSrv' is not assigned and could be declared final | 61 |
| Parameter 'srequest' is not assigned and could be declared final | 69 |
| Parameter 'sresponse' is not assigned and could be declared final | 70 |
| Parameter 'handlerId' is not assigned and could be declared final | 71 |
| Parameter 'attribs' is not assigned and could be declared final | 71 |
| Parameter 'srequest' is not assigned and could be declared final | 83 |
| Parameter 'sresponse' is not assigned and could be declared final | 84 |
| Local variable 'attribResults' could be declared final | 87 |
| Local variable 'returnEidResult' could be declared final | 107 - 108 |
| Violation | Line |
|---|---|
| Private field 'm_objCredDefId' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Private field 'm_objCredDefLoc' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Parameter 'credDefId' is not assigned and could be declared final | 80 |
| Parameter 'cfg' is not assigned and could be declared final | 80 |
| Parameter 'credDefLocation' is not assigned and could be declared final | 80 |
| Local variable 'sp' could be declared final | 91 |
| Local variable 'result' could be declared final | 92 |
| Avoid using Literals in Conditional Statements | 94 |
| Found 'DD'-anomaly for variable 'count' (lines '95'-'119'). | 95 - 119 |
| Found 'DD'-anomaly for variable 'count' (lines '95'-'138'). | 95 - 138 |
| Local variable 'eidAttrs' could be declared final | 96 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 96 |
| Found 'DU'-anomaly for variable 'eidAttrs' (lines '96'-'157'). | 96 - 157 |
| Local variable 'veAttrs' could be declared final | 97 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 97 |
| Found 'DU'-anomaly for variable 'veAttrs' (lines '97'-'157'). | 97 - 157 |
| Found 'DD'-anomaly for variable 'value' (lines '105'-'115'). | 105 - 115 |
| Found 'DD'-anomaly for variable 'rawVal' (lines '106'-'108'). | 106 - 108 |
| Found 'DD'-anomaly for variable 'rawVal' (lines '106'-'112'). | 106 - 112 |
| Found 'DD'-anomaly for variable 'count' (lines '119'-'119'). | 119 |
| Found 'DD'-anomaly for variable 'count' (lines '119'-'138'). | 119 - 138 |
| Found 'DD'-anomaly for variable 'count' (lines '138'-'138'). | 138 |
| Avoid using Literals in Conditional Statements | 190 |
| Local variable 'attribs' could be declared final | 201 |
| Parameter 'eidData' is not assigned and could be declared final | 219 |
| Parameter 'certId' is not assigned and could be declared final | 227 |
| Found 'DD'-anomaly for variable 'result' (lines '236'-'238'). | 236 - 238 |
| Avoid using Literals in Conditional Statements | 237 |
| Local variable 'result' could be declared final | 248 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 248 |
| Local variable 'iv' could be declared final | 270 |
| Local variable 'iter' could be declared final | 271 |
| Local variable 'key' could be declared final | 273 |
| Local variable 'o' could be declared final | 274 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_objLog'. | 56 |
| Private field 'm_objCredDefId' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Private field 'm_objCredDefLoc' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Parameter 'credDefId' is not assigned and could be declared final | 77 |
| Parameter 'cfg' is not assigned and could be declared final | 77 |
| Parameter 'credDefLocation' is not assigned and could be declared final | 77 |
| Local variable 'sp' could be declared final | 88 |
| Local variable 'result' could be declared final | 89 |
| Local variable 'spec' could be declared final | 90 |
| Local variable 'structure' could be declared final | 91 |
| Local variable 'structList' could be declared final | 92 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 93 |
| Avoid using Literals in Conditional Statements | 93 |
| Found 'DU'-anomaly for variable 'count' (lines '94'-'118'). | 94 - 118 |
| Local variable 'dtype' could be declared final | 96 |
| Local variable 'name' could be declared final | 97 |
| Found 'DD'-anomaly for variable 'value' (lines '98'-'101'). | 98 - 101 |
| Found 'DD'-anomaly for variable 'value' (lines '98'-'104'). | 98 - 104 |
| Found 'DD'-anomaly for variable 'value' (lines '98'-'107'). | 98 - 107 |
| Switch statements should have a default label | 99 - 111 |
| Avoid instantiating new objects inside loops | 101 |
| Avoid instantiating new objects inside loops | 104 |
| Avoid instantiating new objects inside loops | 107 |
| Avoid using Literals in Conditional Statements | 151 |
| Local variable 'result' could be declared final | 162 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 162 |
| Local variable 'iv' could be declared final | 164 |
| Local variable 'iter' could be declared final | 165 |
| Local variable 'key' could be declared final | 167 |
| Local variable 'o' could be declared final | 168 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 39 - 111 |
| Private field 'm_objRepo' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'icfg' is not assigned and could be declared final | 52 |
| Use block level rather than method level synchronization | 64 - 68 |
| Parameter 'icfg' is not assigned and could be declared final | 64 |
| Avoid using Literals in Conditional Statements | 65 |
| Parameter 'specId' is not assigned and could be declared final | 74 |
| Found 'DD'-anomaly for variable 'result' (lines '75'-'78'). | 75 - 78 |
| Parameter 'specId' is not assigned and could be declared final | 88 |
| Parameter 'handler' is not assigned and could be declared final | 88 |
| Parameter 'icfg' is not assigned and could be declared final | 99 |
| Avoid using Literals in Conditional Statements | 100 |
| Local variable 'iter' could be declared final | 101 |
| Local variable 'map' could be declared final | 103 |
| Avoid instantiating new objects inside loops | 105 |
| Avoid instantiating new objects inside loops | 107 |
| Violation | Line |
|---|---|
| Private field 'm_strOwnerId' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'timestamp' is not assigned and could be declared final | 50 |
| Parameter 'status' is not assigned and could be declared final | 50 |
| Parameter 'ownerId' is not assigned and could be declared final | 50 |
| Parameter 'timestamp' is not assigned and could be declared final | 85 |
| Parameter 'status' is not assigned and could be declared final | 103 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 41 - 208 |
| Private field 'm_objCertRepo' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Private field 'm_objCrl' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Private field 'm_objIdMap' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Avoid unused constructor parameters such as 'cfg'. | 64 - 69 |
| Parameter 'cfg' is not assigned and could be declared final | 64 |
| Use block level rather than method level synchronization | 77 - 86 |
| Parameter 'cfg' is not assigned and could be declared final | 77 |
| Avoid using Literals in Conditional Statements | 80 |
| Parameter 'ownerId' is not assigned and could be declared final | 92 |
| Parameter 'uuid' is not assigned and could be declared final | 92 |
| Local variable 'cert' could be declared final | 94 |
| Parameter 'uuid' is not assigned and could be declared final | 107 |
| Found 'DD'-anomaly for variable 'result' (lines '110'-'115'). | 110 - 115 |
| Avoid using Literals in Conditional Statements | 112 |
| Local variable 'ownerId' could be declared final | 113 |
| Avoid using Literals in Conditional Statements | 114 |
| Parameter 'ownerId' is not assigned and could be declared final | 128 |
| Found 'DD'-anomaly for variable 'result' (lines '131'-'137'). | 131 - 137 |
| Avoid using Literals in Conditional Statements | 133 |
| Local variable 'cert' could be declared final | 135 |
| Avoid using Literals in Conditional Statements | 136 |
| Local variable 'cert' could be declared final | 141 |
| Deeply nested if..then statements are hard to read | 142 - 143 |
| Avoid using Literals in Conditional Statements | 142 |
| Parameter 'ownerId' is not assigned and could be declared final | 157 |
| Found 'DD'-anomaly for variable 'cert' (lines '160'-'162'). | 160 - 162 |
| Avoid if (x != y) ..; else ..; | 163 - 167 |
| Avoid using Literals in Conditional Statements | 163 |
| Assigning an Object to null is a code smell. Consider refactoring. | 167 |
| Avoid if (x != y) ..; else ..; | 169 - 176 |
| Avoid using Literals in Conditional Statements | 169 |
| Parameter 'uuid' is not assigned and could be declared final | 185 |
| Avoid unused local variables such as 'cert'. | 188 |
| Local variable 'cert' could be declared final | 188 |
| Found 'DU'-anomaly for variable 'cert' (lines '188'-'195'). | 188 - 195 |
| Local variable 'ownerId' could be declared final | 189 |
| Avoid using Literals in Conditional Statements | 190 |
| Local variable 'returnString' could be declared final | 204 |
| Violation | Line |
|---|---|
| Private field 'm_objBaseDir' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Parameter 'cfg' is not assigned and could be declared final | 54 |
| Local variable 'baseDir' could be declared final | 56 |
| Found 'DD'-anomaly for variable 'result' (lines '72'-'74'). | 72 - 74 |
| Parameter 'absoluteFileName' is not assigned and could be declared final | 92 |
| Local variable 'f' could be declared final | 95 |
| Parameter 'content' is not assigned and could be declared final | 107 |
| Found 'DD'-anomaly for variable 'result' (lines '110'-'117'). | 110 - 117 |
| Avoid using Literals in Conditional Statements | 112 |
| Local variable 'fileName' could be declared final | 114 |
| Violation | Line |
|---|---|
| Private field 'm_bValid' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'm_objProof' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Parameter 'proof' is not assigned and could be declared final | 52 |
| Parameter 'isValid' is not assigned and could be declared final | 52 |
| Parameter 'name' is not assigned and could be declared final | 83 |
| Found 'DD'-anomaly for variable 'result' (lines '84'-'87'). | 84 - 87 |
| Avoid using Literals in Conditional Statements | 86 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 43 - 160 |
| Private field 'm_objVerifierRepo' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field 'm_objTimeRepo' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Parameter 'cfg' is not assigned and could be declared final | 71 |
| Use block level rather than method level synchronization | 86 - 91 |
| Parameter 'config' is not assigned and could be declared final | 86 |
| Avoid using Literals in Conditional Statements | 87 |
| Parameter 'specUri' is not assigned and could be declared final | 105 |
| Found 'DD'-anomaly for variable 'result' (lines '106'-'108'). | 106 - 108 |
| Local variable 'id' could be declared final | 109 |
| Parameter 'uuid' is not assigned and could be declared final | 122 |
| Found 'DD'-anomaly for variable 'result' (lines '123'-'125'). | 123 - 125 |
| Avoid if (x != y) ..; else ..; | 126 - 131 |
| Avoid using Literals in Conditional Statements | 126 |
| Local variable 'currentTime' could be declared final | 141 |
| Found 'DU'-anomaly for variable 'currentTime' (lines '141'-'158'). | 141 - 158 |
| Local variable 'iter' could be declared final | 143 |
| Local variable 'candidates' could be declared final | 144 |
| Local variable 'key' could be declared final | 146 |
| Local variable 'val' could be declared final | 147 |
| Violation | Line |
|---|---|
| Private field 'm_objCfg' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Private field 'm_strStructId' could be made final; it is only initialized in the declaration or constructor. | 71 |
| Parameter 'specUri' is not assigned and could be declared final | 82 |
| Parameter 'cfg' is not assigned and could be declared final | 82 |
| Avoid using Literals in Conditional Statements | 95 |
| Found 'DD'-anomaly for variable 'result' (lines '111'-'113'). | 111 - 113 |
| Parameter 'msg' is not assigned and could be declared final | 131 |
| Local variable 'returnString' could be declared final | 134 |
| Parameter 'proof' is not assigned and could be declared final | 145 |
| Found 'DD'-anomaly for variable 'result' (lines '148'-'165'). | 148 - 165 |
| Local variable 'encs' could be declared final | 152 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 156 |
| Avoid using Literals in Conditional Statements | 156 |
| Local variable 'spec' could be declared final | 159 |
| Local variable 'isValid' could be declared final | 163 |
| Parameter 'str' is not assigned and could be declared final | 180 |
| Found 'DD'-anomaly for variable 'result' (lines '183'-'185'). | 183 - 185 |
| Parameter 'enc' is not assigned and could be declared final | 202 |
| Found 'DD'-anomaly for variable 'result' (lines '205'-'208'). | 205 - 208 |
| Avoid using Literals in Conditional Statements | 207 |
| Found 'DD'-anomaly for variable 'result' (lines '224'-'230'). | 224 - 230 |
| Avoid using Literals in Conditional Statements | 226 |
| Local variable 'values' could be declared final | 228 |
| Avoid using Literals in Conditional Statements | 229 |
| Local variable 'iter' could be declared final | 231 |
| Local variable 'key' could be declared final | 233 |
| Avoid instantiating new objects inside loops | 236 |
| Local variable 'result' could be declared final | 261 |
| Avoid using Literals in Conditional Statements | 263 |
| Local variable 'values' could be declared final | 265 |
| Local variable 'iter' could be declared final | 266 |
| Local variable 'key' could be declared final | 268 |
| Avoid instantiating new objects inside loops | 269 |
