The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 64 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 - 45 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 65 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 55 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 54 |
| Violation | Line |
|---|---|
| Parameter 't' is not assigned and could be declared final | 49 |
| Parameter 'errorMsg' is not assigned and could be declared final | 49 |
| Parameter 'resultData' is not assigned and could be declared final | 59 |
| Violation | Line |
|---|---|
| Private field 'm_objMgr' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Parameter 'msStore' is not assigned and could be declared final | 65 |
| Parameter 'credStore' is not assigned and could be declared final | 66 |
| Parameter 'tmpStore' is not assigned and could be declared final | 66 |
| Parameter 'request' is not assigned and could be declared final | 75 |
| Local variable 'dr' could be declared final | 81 |
| Avoid using Literals in Conditional Statements | 82 |
| Parameter 'request' is not assigned and could be declared final | 102 |
| Local variable 'ir' could be declared final | 108 |
| Avoid using Literals in Conditional Statements | 109 |
| Parameter 'response' is not assigned and could be declared final | 125 |
| Local variable 'ir' could be declared final | 131 |
| Avoid using Literals in Conditional Statements | 132 |
| Violation | Line |
|---|---|
| Private field 'm_objMgr' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Parameter 'msStore' is not assigned and could be declared final | 65 |
| Parameter 'credStore' is not assigned and could be declared final | 66 |
| Parameter 'proofStore' is not assigned and could be declared final | 66 |
| Parameter 'request' is not assigned and could be declared final | 74 |
| Found 'DD'-anomaly for variable 'result' (lines '77'-'79'). | 77 - 79 |
| Parameter 'parser' is not assigned and could be declared final | 92 |
| Local variable 'resp' could be declared final | 98 |
| Avoid using Literals in Conditional Statements | 99 |
| Parameter 'request' is not assigned and could be declared final | 116 |
| Parameter 'callbackInvoker' is not assigned and could be declared final | 117 |
| Local variable 'parser' could be declared final | 123 |
| Local variable 'uiresult' could be declared final | 124 - 125 |
| Local variable 'presp' could be declared final | 128 - 129 |
| Avoid using Literals in Conditional Statements | 130 |
| Avoid empty if statements | 133 - 135 |
| Violation | Line |
|---|---|
| The class 'RevocationServiceClient' has a Cyclomatic Complexity of 5 (Highest = 10). | 50 - 159 |
| Private field 'm_objProver' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Parameter 'proverService' is not assigned and could be declared final | 68 |
| Parameter 'credStore' is not assigned and could be declared final | 69 |
| Parameter 'request' is not assigned and could be declared final | 78 |
| Parameter 'callbackInvoker' is not assigned and could be declared final | 79 |
| Local variable 'preq' could be declared final | 90 |
| Local variable 'presp' could be declared final | 97 - 98 |
| Avoid using Literals in Conditional Statements | 100 |
| The method 'revoke' has a Cyclomatic Complexity of 10. | 123 - 157 |
| Parameter 'values' is not assigned and could be declared final | 123 |
| Parameter 'pkUri' is not assigned and could be declared final | 123 |
| Found 'DD'-anomaly for variable 'result' (lines '126'-'148'). | 126 - 148 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 128 |
| Local variable 'creds' could be declared final | 129 |
| Found 'DD'-anomaly for variable 'foundCert' (lines '134'-'138'). | 134 - 138 |
| Local variable 'val' could be declared final | 136 |
| Deeply nested if..then statements are hard to read | 137 - 140 |
| Deeply nested if..then statements are hard to read | 142 - 150 |
| Violation | Line |
|---|---|
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Private field 'm_objMsStore' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Private field 'm_objTmpStore' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Parameter 'credStore' is not assigned and could be declared final | 81 |
| Parameter 'tmpStore' is not assigned and could be declared final | 81 |
| Parameter 'msStorage' is not assigned and could be declared final | 81 |
| Parameter 'request' is not assigned and could be declared final | 96 |
| Local variable 'cred' could be declared final | 98 |
| Local variable 'replyTo' could be declared final | 99 |
| Local variable 'ipk' could be declared final | 100 |
| Local variable 'gp' could be declared final | 101 |
| Local variable 'returnIssueDataRequestType' could be declared final | 109 - 110 |
| Parameter 'request' is not assigned and could be declared final | 123 |
| Found 'DD'-anomaly for variable 'result' (lines '125'-'153'). | 125 - 153 |
| Local variable 'nonce' could be declared final | 127 |
| Local variable 'replyTo' could be declared final | 128 |
| Local variable 'serviceId' could be declared final | 129 |
| Local variable 'attribData' could be declared final | 135 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 137 |
| Found 'DD'-anomaly for variable 'attributes' (lines '137'-'146'). | 137 - 146 |
| Local variable 'encs' could be declared final | 139 |
| Local variable 'value' could be declared final | 141 |
| Local variable 'key' could be declared final | 142 |
| Found 'DD'-anomaly for variable 'resultMsg' (lines '151'-'152'). | 151 - 152 |
| Parameter 'content' is not assigned and could be declared final | 171 |
| Found 'DD'-anomaly for variable 'result' (lines '174'-'185'). | 174 - 185 |
| Avoid using Literals in Conditional Statements | 182 |
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 66 - 548 |
| Too many fields | 66 - 548 |
| Parameter 'replyTo' is not assigned and could be declared final | 138 |
| Parameter 'cred' is not assigned and could be declared final | 138 |
| Parameter 'ipk' is not assigned and could be declared final | 138 |
| Parameter 'gp' is not assigned and could be declared final | 138 |
| Parameter 'tmpStorage' is not assigned and could be declared final | 139 |
| Parameter 'msStorage' is not assigned and could be declared final | 139 |
| Parameter 's' is not assigned and could be declared final | 171 |
| Found 'DD'-anomaly for variable 'result' (lines '174'-'177'). | 174 - 177 |
| Found 'DD'-anomaly for variable 'masterSecret' (lines '198'-'200'). | 198 - 200 |
| Avoid using Literals in Conditional Statements | 204 |
| Found 'DU'-anomaly for variable 'masterSecret' (lines '205'-'212'). | 205 - 212 |
| Local variable 'returnString' could be declared final | 222 |
| Parameter 'nonce' is not assigned and could be declared final | 245 |
| Found 'DD'-anomaly for variable 'result' (lines '248'-'272'). | 248 - 272 |
| Local variable 'masterSecret' could be declared final | 251 |
| Local variable 'values' could be declared final | 252 |
| Local variable 'iter' could be declared final | 256 |
| Local variable 'key' could be declared final | 258 |
| Local variable 'value' could be declared final | 259 |
| Local variable 'mapVal' could be declared final | 266 |
| Local variable 'msg' could be declared final | 268 |
| Local variable 'oresult' could be declared final | 271 |
| Avoid using Literals in Conditional Statements | 292 |
| Parameter 'message' is not assigned and could be declared final | 305 |
| Found 'DD'-anomaly for variable 'result' (lines '308'-'312'). | 308 - 312 |
| Local variable 'msg' could be declared final | 310 |
| Avoid using Literals in Conditional Statements | 311 |
| Avoid using Literals in Conditional Statements | 313 |
| Local variable 'attribs' could be declared final | 314 |
| Deeply nested if..then statements are hard to read | 315 - 324 |
| Avoid using Literals in Conditional Statements | 315 |
| Local variable 'iter' could be declared final | 316 |
| Local variable 'attrib' could be declared final | 318 |
| Local variable 'returnString' could be declared final | 345 |
| Local variable 'returnString' could be declared final | 358 |
| Parameter 'values' is not assigned and could be declared final | 369 |
| Local variable 'returnString' could be declared final | 398 |
| Parameter 'contentAsB64' is not assigned and could be declared final | 408 |
| Parameter 'storage' is not assigned and could be declared final | 421 |
| Local variable 'skFile' could be declared final | 435 |
| Local variable 'pkFile' could be declared final | 436 |
| Local variable 'sysParams' could be declared final | 438 |
| Local variable 'skUri' could be declared final | 439 |
| Local variable 'pkUri' could be declared final | 440 |
| Local variable 'result' could be declared final | 459 |
| Avoid if (x != y) ..; else ..; | 462 - 471 |
| Avoid using Literals in Conditional Statements | 462 |
| Local variable 'idm' could be declared final | 464 |
| Parameter 'nonce' is not assigned and could be declared final | 496 |
| Parameter 'serviceID' is not assigned and could be declared final | 509 |
| Parameter 'enc' is not assigned and could be declared final | 535 |
| Found 'DD'-anomaly for variable 'result' (lines '538'-'540'). | 538 - 540 |
| Avoid using Literals in Conditional Statements | 539 |
| Violation | Line |
|---|---|
| The class 'ProveContext' has a Cyclomatic Complexity of 3 (Highest = 20). | 62 - 449 |
| Private field 'm_objProofUri' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 75 |
| Private field 'm_objMsStore' could be made final; it is only initialized in the declaration or constructor. | 84 |
| Private field 'm_strNonce' could be made final; it is only initialized in the declaration or constructor. | 87 |
| Private field 'm_objReplyTo' could be made final; it is only initialized in the declaration or constructor. | 90 |
| Parameter 'replyTo' is not assigned and could be declared final | 105 |
| Parameter 'nonce' is not assigned and could be declared final | 105 |
| Parameter 'proof' is not assigned and could be declared final | 105 |
| Parameter 'msStorage' is not assigned and could be declared final | 106 |
| Parameter 'storage' is not assigned and could be declared final | 106 |
| Parameter 'replyTo' is not assigned and could be declared final | 126 |
| Parameter 'nonce' is not assigned and could be declared final | 126 |
| Parameter 'proof' is not assigned and could be declared final | 126 |
| Parameter 'msStorage' is not assigned and could be declared final | 127 |
| Parameter 'storage' is not assigned and could be declared final | 127 |
| Avoid unused private methods such as 'parseUri(String)'. | 143 |
| Parameter 's' is not assigned and could be declared final | 143 |
| Found 'DD'-anomaly for variable 'result' (lines '146'-'149'). | 146 - 149 |
| Avoid using Literals in Conditional Statements | 175 |
| Avoid using Literals in Conditional Statements | 179 |
| Avoid using Literals in Conditional Statements | 183 |
| Avoid using Literals in Conditional Statements | 191 |
| Local variable 'returnProof' could be declared final | 209 |
| Avoid really long methods. | 222 - 342 |
| The method 'createProof' has a Cyclomatic Complexity of 20. | 222 - 342 |
| Parameter 'nonce' is not assigned and could be declared final | 222 |
| Local variable 'masterSecret' could be declared final | 227 |
| Local variable 'credMap' could be declared final | 230 |
| Found 'DU'-anomaly for variable 'credMap' (lines '230'-'342'). | 230 - 342 |
| Local variable 'vencMap' could be declared final | 231 |
| Found 'DU'-anomaly for variable 'vencMap' (lines '231'-'342'). | 231 - 342 |
| Local variable 'credPkMap' could be declared final | 234 |
| Found 'DU'-anomaly for variable 'credPkMap' (lines '234'-'342'). | 234 - 342 |
| Found 'DU'-anomaly for variable 'hasVe' (lines '237'-'342'). | 237 - 342 |
| Found 'DD'-anomaly for variable 'hasVe' (lines '237'-'264'). | 237 - 264 |
| Avoid using Literals in Conditional Statements | 238 |
| Local variable 'pred' could be declared final | 242 |
| Local variable 'clpred' could be declared final | 244 |
| Local variable 'credUri' could be declared final | 245 - 246 |
| Local variable 'ipkUri' could be declared final | 247 - 248 |
| Local variable 'credInst' could be declared final | 249 - 250 |
| Avoid if (x != y) ..; else ..; | 251 - 261 |
| Avoid using Literals in Conditional Statements | 251 |
| Local variable 'tmpName' could be declared final | 252 |
| Found 'DU'-anomaly for variable 'hasVe' (lines '264'-'342'). | 264 - 342 |
| Found 'DD'-anomaly for variable 'hasVe' (lines '264'-'264'). | 264 |
| Local variable 'pred' could be declared final | 272 |
| Local variable 'verpred' could be declared final | 275 |
| Local variable 'credPkUri' could be declared final | 278 |
| Local variable 'name' could be declared final | 281 |
| Local variable 'cred' could be declared final | 282 |
| Deeply nested if..then statements are hard to read | 285 - 301 |
| Local variable 'value' could be declared final | 288 - 289 |
| Avoid using Literals in Conditional Statements | 290 |
| Local variable 'pkUri' could be declared final | 291 - 292 |
| Local variable 'label' could be declared final | 293 |
| Local variable 'pk' could be declared final | 294 |
| Local variable 'random' could be declared final | 295 |
| Local variable 'vencName' could be declared final | 296 |
| Local variable 'enc' could be declared final | 297 - 298 |
| Avoid instantiating new objects inside loops | 297 - 298 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 314 |
| Avoid using Literals in Conditional Statements | 314 |
| Local variable 'returnString' could be declared final | 364 |
| Found 'DD'-anomaly for variable 'result' (lines '389'-'391'). | 389 - 391 |
| Local variable 'returnString' could be declared final | 405 |
| Avoid using Literals in Conditional Statements | 418 |
| Parameter 'storage' is not assigned and could be declared final | 430 |
| Violation | Line |
|---|---|
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Private field 'm_objMsStore' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Private field 'm_objProofStore' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Parameter 'credStore' is not assigned and could be declared final | 72 |
| Parameter 'proofStore' is not assigned and could be declared final | 72 |
| Parameter 'msStorage' is not assigned and could be declared final | 72 |
| Parameter 'request' is not assigned and could be declared final | 86 |
| Found 'DD'-anomaly for variable 'result' (lines '89'-'106'). | 89 - 106 |
| Local variable 'nonce' could be declared final | 91 |
| Local variable 'replyTo' could be declared final | 92 |
| Local variable 'proofSpec' could be declared final | 93 |
| Found 'DD'-anomaly for variable 'proof' (lines '97'-'100'). | 97 - 100 |
| Found 'DD'-anomaly for variable 'error' (lines '98'-'104'). | 98 - 104 |
| Parameter 'parser' is not assigned and could be declared final | 123 |
| Found 'DD'-anomaly for variable 'result' (lines '126'-'132'). | 126 - 132 |
| Local variable 'resultMsg' could be declared final | 131 |
| Violation | Line |
|---|---|
| Parameter 't' is not assigned and could be declared final | 38 |
| Parameter 's' is not assigned and could be declared final | 47 |
| Violation | Line |
|---|---|
| Document empty constructor | 36 |
| It is a good practice to call super() in a constructor | 36 |
| Parameter 's' is not assigned and could be declared final | 43 |
| Parameter 't' is not assigned and could be declared final | 52 |
| Violation | Line |
|---|---|
| Private field 'm_numType' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Parameter 's' is not assigned and could be declared final | 57 |
| Parameter 'type' is not assigned and could be declared final | 57 |
