The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| Private field 'm_objClient' could be made final; it is only initialized in the declaration or constructor. | 73 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Found 'DU'-anomaly for variable 'result' (lines '94'-'157'). | 94 - 157 |
| Local variable 'sslContext' could be declared final | 97 |
| Return an empty array rather than null. | 101 - 104 |
| Parameter 'certs' is not assigned and could be declared final | 106 |
| Parameter 'authType' is not assigned and could be declared final | 107 |
| Parameter 'certs' is not assigned and could be declared final | 111 |
| Parameter 'authType' is not assigned and could be declared final | 112 |
| Local variable 'sf' could be declared final | 117 |
| Parameter 'arg1' is not assigned and could be declared final | 121 |
| Parameter 'arg0' is not assigned and could be declared final | 121 |
| Parameter 'arg2' is not assigned and could be declared final | 127 |
| Parameter 'arg1' is not assigned and could be declared final | 127 |
| Parameter 'arg0' is not assigned and could be declared final | 127 |
| Parameter 'arg1' is not assigned and could be declared final | 134 |
| Parameter 'arg0' is not assigned and could be declared final | 134 |
| Parameter 'arg1' is not assigned and could be declared final | 140 |
| Parameter 'arg0' is not assigned and could be declared final | 140 |
| Local variable 'httpsScheme' could be declared final | 145 |
| Local variable 'schemeRegistry' could be declared final | 146 |
| Local variable 'params' could be declared final | 149 |
| Local variable 'cm' could be declared final | 150 - 151 |
| Parameter 'url' is not assigned and could be declared final | 165 |
| Found 'DD'-anomaly for variable 'result' (lines '166'-'174'). | 166 - 174 |
| Local variable 'params' could be declared final | 170 |
| Parameter 'content' is not assigned and could be declared final | 189 |
| Parameter 'url' is not assigned and could be declared final | 189 |
| Found 'DD'-anomaly for variable 'result' (lines '190'-'196'). | 190 - 196 |
| Parameter 'content' is not assigned and could be declared final | 211 |
| Parameter 'url' is not assigned and could be declared final | 211 |
| Found 'DD'-anomaly for variable 'result' (lines '212'-'220'). | 212 - 220 |
| Local variable 'strResp' could be declared final | 218 |
| Parameter 'resp' is not assigned and could be declared final | 236 |
| Found 'DD'-anomaly for variable 'result' (lines '237'-'248'). | 237 - 248 |
| Local variable 'in' could be declared final | 240 |
| Local variable 'reader' could be declared final | 241 - 242 |
| Found 'DD'-anomaly for variable 'line' (lines '243'-'245'). | 243 - 245 |
| Local variable 'buffer' could be declared final | 244 |
| Avoid assignments in operands | 245 |
| Found 'DU'-anomaly for variable 'line' (lines '245'-'252'). | 245 - 252 |
| Avoid unused private fields such as 'delegate'. | 260 |
| It is a good practice to call super() in a constructor | 267 - 269 |
| Parameter 'host' is not assigned and could be declared final | 275 |
| Parameter 'cns' is not assigned and could be declared final | 275 |
| Parameter 'subjectAlts' is not assigned and could be declared final | 275 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 55 - 225 |
| Parameter 'args' is not assigned and could be declared final | 78 |
| Local variable 'server' could be declared final | 79 |
| Local variable 'factory' could be declared final | 80 |
| Local variable 'ks' could be declared final | 81 |
| Local variable 'sslConnector' could be declared final | 87 |
| Local variable 'webapp' could be declared final | 96 |
| Parameter 'pass' is not assigned and could be declared final | 115 |
| Found 'DD'-anomaly for variable 'result' (lines '116'-'121'). | 116 - 121 |
| Local variable 'keyPairGenerator' could be declared final | 125 - 126 |
| Local variable 'KPair' could be declared final | 128 |
| Local variable 'v3CertGen' could be declared final | 129 |
| Local variable 'serial' could be declared final | 130 |
| Local variable 'PKCertificate' could be declared final | 143 - 144 |
| Avoid using java.lang.ThreadGroup; it is not thread safe | 148 |
| Found 'DD'-anomaly for variable 'result' (lines '165'-'168'). | 165 - 168 |
| Local variable 'uHome' could be declared final | 166 |
| Avoid using Literals in Conditional Statements | 167 |
| Found 'DD'-anomaly for variable 'result' (lines '179'-'182'). | 179 - 182 |
| Local variable 'f' could be declared final | 181 |
| Found 'DD'-anomaly for variable 'result' (lines '193'-'197'). | 193 - 197 |
| Avoid empty catch blocks | 198 - 199 |
| Found 'DD'-anomaly for variable 'result' (lines '211'-'218'). | 211 - 218 |
| Local variable 'f' could be declared final | 214 |
| Avoid empty catch blocks | 219 - 220 |
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 60 |
| Parameter 'defVal' is not assigned and could be declared final | 60 |
| Parameter 'caption' is not assigned and could be declared final | 60 |
| Parameter 'str' is not assigned and could be declared final | 108 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'113'). | 109 - 113 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'115'). | 109 - 115 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'117'). | 109 - 117 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'119'). | 109 - 119 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'121'). | 109 - 121 |
| Found 'DD'-anomaly for variable 'result' (lines '109'-'123'). | 109 - 123 |
| Violation | Line |
|---|---|
| Private field 'm_objLog' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Avoid unused private fields such as 'm_objResp'. | 65 |
| Perhaps 'm_objResp' could be replaced by a local variable. | 65 |
| Use block level rather than method level synchronization | 71 - 79 |
| Avoid using Literals in Conditional Statements | 72 |
| Local variable 'mainWindow' could be declared final | 73 |
| Parameter 'request' is not assigned and could be declared final | 84 |
| Parameter 'response' is not assigned and could be declared final | 85 |
| Avoid if (x != y) ..; else ..; | 90 - 108 |
| Avoid using Literals in Conditional Statements | 90 |
| Local variable 'ctx' could be declared final | 94 |
| Parameter 'request' is not assigned and could be declared final | 114 |
| Document empty method | 115 - 116 |
| Parameter 'response' is not assigned and could be declared final | 115 |
| Parameter 'ctx' is not assigned and could be declared final | 122 |
| Avoid using Literals in Conditional Statements | 123 |
| Switch statements should have a default label | 124 - 136 |
| Parameter 'url' is not assigned and could be declared final | 145 |
| Local variable 'source' could be declared final | 161 - 167 |
| Found 'DU'-anomaly for variable 'source' (lines '161'-'173'). | 161 - 173 |
| Found 'DU'-anomaly for variable 'source' (lines '161'-'173'). | 161 - 173 |
| Parameter 'req' is not assigned and could be declared final | 181 |
| Found 'DD'-anomaly for variable 'result' (lines '182'-'185'). | 182 - 185 |
| Local variable 'reqUri' could be declared final | 183 |
| Avoid using Literals in Conditional Statements | 184 |
| Parameter 'timeout' is not assigned and could be declared final | 197 |
| Avoid using Literals in Conditional Statements | 198 |
| Avoid if (x != y) ..; else ..; | 208 - 211 |
| Violation | Line |
|---|---|
| Parameter 'location' is not assigned and could be declared final | 104 |
| Use block level rather than method level synchronization | 113 - 122 |
| Found 'DD'-anomaly for variable 'result' (lines '114'-'117'). | 114 - 117 |
| Use block level rather than method level synchronization | 129 - 132 |
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 55 - 444 |
| Private field 'm_objSettings' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Perhaps 'm_objSettings' could be replaced by a local variable. | 62 |
| Private field 'm_objLogout' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Perhaps 'm_objLogout' could be replaced by a local variable. | 65 |
| Private field 'm_objPinDialog' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Private field 'm_objLogoutLayout' could be made final; it is only initialized in the declaration or constructor. | 83 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 86 |
| Parameter 'listener' is not assigned and could be declared final | 101 |
| It is a good practice to call super() in a constructor | 101 - 158 |
| Found 'DU'-anomaly for variable 'clone' (lines '105'-'158'). | 105 - 158 |
| Found 'DU'-anomaly for variable 'clone' (lines '105'-'158'). | 105 - 158 |
| Found 'DU'-anomaly for variable 'clone' (lines '105'-'158'). | 105 - 158 |
| Local variable 'mlistener' could be declared final | 106 - 119 |
| Found 'DU'-anomaly for variable 'mlistener' (lines '106'-'158'). | 106 - 158 |
| Found 'DU'-anomaly for variable 'mlistener' (lines '106'-'158'). | 106 - 158 |
| Found 'DU'-anomaly for variable 'mlistener' (lines '106'-'158'). | 106 - 158 |
| Parameter 'cmd' is not assigned and could be declared final | 109 |
| Parameter 'o' is not assigned and could be declared final | 109 |
| Switch statements should have a default label | 110 - 116 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 110 - 116 |
| Parameter 'event' is not assigned and could be declared final | 130 |
| Local variable 'spacer' could be declared final | 140 |
| Parameter 'event' is not assigned and could be declared final | 149 |
| Avoid if (x != y) ..; else ..; | 167 - 170 |
| Avoid using Literals in Conditional Statements | 167 |
| Parameter 'timeout' is not assigned and could be declared final | 181 |
| Assigning an Object to null is a code smell. Consider refactoring. | 187 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Parameter 'data' is not assigned and could be declared final | 206 |
| Avoid using Literals in Conditional Statements | 207 |
| Avoid using Literals in Conditional Statements | 208 |
| Local variable 'isAvail' could be declared final | 227 |
| Avoid if (x != y) ..; else ..; | 229 - 235 |
| Parameter 'ctx' is not assigned and could be declared final | 260 |
| Assigning an Object to null is a code smell. Consider refactoring. | 269 |
| Parameter 'password' is not assigned and could be declared final | 278 |
| Found 'DD'-anomaly for variable 'result' (lines '279'-'287'). | 279 - 287 |
| Avoid using Literals in Conditional Statements | 281 |
| Avoid using Literals in Conditional Statements | 285 |
| Avoid using Literals in Conditional Statements | 289 |
| Found 'DD'-anomaly for variable 'outputmsg' (lines '294'-'298'). | 294 - 298 |
| Found 'DD'-anomaly for variable 'outputmsg' (lines '294'-'303'). | 294 - 303 |
| Switch statements should have a default label | 295 - 305 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 295 - 305 |
| Local variable 'file' could be declared final | 297 |
| Found 'DU'-anomaly for variable 'pass2' (lines '328'-'393'). | 328 - 393 |
| Found 'DU'-anomaly for variable 'pass2' (lines '328'-'393'). | 328 - 393 |
| Found 'DU'-anomaly for variable 'pass2' (lines '328'-'393'). | 328 - 393 |
| Local variable 'listener1' could be declared final | 334 - 357 |
| Found 'DU'-anomaly for variable 'listener1' (lines '334'-'393'). | 334 - 393 |
| Found 'DU'-anomaly for variable 'listener1' (lines '334'-'393'). | 334 - 393 |
| Found 'DU'-anomaly for variable 'listener1' (lines '334'-'393'). | 334 - 393 |
| Parameter 'cmd' is not assigned and could be declared final | 337 |
| Parameter 'o' is not assigned and could be declared final | 337 |
| Avoid using Literals in Conditional Statements | 338 |
| Avoid using Literals in Conditional Statements | 346 |
| Local variable 'listener2' could be declared final | 359 - 387 |
| Parameter 'cmd' is not assigned and could be declared final | 362 |
| Parameter 'o' is not assigned and could be declared final | 362 |
| Parameter 'cmd' is not assigned and could be declared final | 399 |
| Parameter 'o' is not assigned and could be declared final | 399 |
| Local variable 'result' could be declared final | 400 |
| Avoid using Literals in Conditional Statements | 402 |
| Switch statements should have a default label | 403 - 407 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 403 - 407 |
| Local variable 'cfg' could be declared final | 417 |
| Found 'DU'-anomaly for variable 'cfg' (lines '417'-'435'). | 417 - 435 |
| Local variable 'strVal' could be declared final | 419 |
| Found 'DD'-anomaly for variable 'val' (lines '420'-'422'). | 420 - 422 |
| Found 'DU'-anomaly for variable 'val' (lines '420'-'435'). | 420 - 435 |
| Found 'DD'-anomaly for variable 'val' (lines '420'-'420'). | 420 |
| Avoid using Literals in Conditional Statements | 421 |
| Found 'DD'-anomaly for variable 'val' (lines '422'-'420'). | 422 - 420 |
| Found 'DU'-anomaly for variable 'val' (lines '422'-'435'). | 422 - 435 |
| Switch statements should have a default label | 424 - 433 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 424 - 433 |
| Parameter 'timeout' is not assigned and could be declared final | 441 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'de.fub.mi.idenpa.generated.ProveResultType' | 43 |
| The class 'NavigationTab' has a Cyclomatic Complexity of 3 (Highest = 11). | 62 - 259 |
| Private field 'm_objLog' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Avoid unused private fields such as 'm_objStorage'. | 75 |
| Perhaps 'm_objStorage' could be replaced by a local variable. | 75 |
| Parameter 'servletListener' is not assigned and could be declared final | 107 |
| Parameter 'storage' is not assigned and could be declared final | 107 |
| It is a good practice to call super() in a constructor | 107 - 132 |
| Avoid using Literals in Conditional Statements | 142 |
| Local variable 'tab' could be declared final | 144 - 145 |
| Avoid using Literals in Conditional Statements | 158 |
| Local variable 'tab' could be declared final | 160 - 161 |
| Avoid using Literals in Conditional Statements | 174 |
| Local variable 'tab' could be declared final | 176 - 177 |
| The method 'tranceive' has a Cyclomatic Complexity of 11. | 188 - 214 |
| Parameter 'cmd' is not assigned and could be declared final | 188 |
| Parameter 'o' is not assigned and could be declared final | 188 |
| Local variable 'result' could be declared final | 189 |
| Switch statements should have a default label | 191 - 211 |
| No need to check for null before an instanceof | 197 |
| No need to check for null before an instanceof | 202 |
| No need to check for null before an instanceof | 207 |
| Assigning an Object to null is a code smell. Consider refactoring. | 220 |
| Assigning an Object to null is a code smell. Consider refactoring. | 221 |
| Assigning an Object to null is a code smell. Consider refactoring. | 222 |
| Parameter 'data' is not assigned and could be declared final | 230 |
| Local variable 'className' could be declared final | 231 |
| Parameter 'visible' is not assigned and could be declared final | 256 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_objLog'. | 56 |
| Private field 'm_objPass' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Private field 'm_objIntro' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Private field 'm_objContinue' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Private field 'm_objClear' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Parameter 'listener' is not assigned and could be declared final | 79 |
| It is a good practice to call super() in a constructor | 79 - 101 |
| Parameter 'label' is not assigned and could be declared final | 108 |
| Parameter 'listener' is not assigned and could be declared final | 117 |
| Local variable 'diggits' could be declared final | 125 |
| Do not add empty strings | 127 |
| Local variable 'b' could be declared final | 127 |
| Avoid instantiating new objects inside loops | 127 |
| Local variable 'b' could be declared final | 134 |
| Local variable 'layout' could be declared final | 144 |
| Avoid using Literals in Conditional Statements | 151 |
| Parameter 'event' is not assigned and could be declared final | 169 |
| Avoid using Literals in Conditional Statements | 178 |
| These nested if statements could be combined | 179 - 187 |
| Found 'DD'-anomaly for variable 'current' (lines '180'-'182'). | 180 - 182 |
| Deeply nested if..then statements are hard to read | 181 - 182 |
| Avoid using Literals in Conditional Statements | 181 |
| Deeply nested if..then statements are hard to read | 183 - 186 |
| Avoid using Literals in Conditional Statements | 183 |
| Prefer StringBuffer over += for concatenating strings | 184 |
| Parameter 'event' is not assigned and could be declared final | 196 |
| Parameter 'text' is not assigned and could be declared final | 205 |
| Avoid using Literals in Conditional Statements | 208 |
| Avoid using Literals in Conditional Statements | 213 |
| Violation | Line |
|---|---|
| Private field 'm_objSettings' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Private field 'm_objBtSave' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Private field 'm_objBtCancel' could be made final; it is only initialized in the declaration or constructor. | 62 |
| Perhaps 'm_objBtCancel' could be replaced by a local variable. | 62 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Parameter 'listener' is not assigned and could be declared final | 76 |
| Parameter 'storage' is not assigned and could be declared final | 76 |
| It is a good practice to call super() in a constructor | 76 - 114 |
| Local variable 'values' could be declared final | 81 |
| Local variable 'vallength' could be declared final | 82 |
| Local variable 'cap' could be declared final | 88 |
| Avoid instantiating new objects inside loops | 88 |
| Local variable 'cmp' could be declared final | 91 |
| Local variable 'strVal' could be declared final | 92 |
| Avoid using Literals in Conditional Statements | 94 |
| Local variable 'hl' could be declared final | 108 |
| Parameter 'event' is not assigned and could be declared final | 120 |
| Local variable 'cwindow' could be declared final | 125 |
| Local variable 'settings' could be declared final | 133 |
| Local variable 'current' could be declared final | 136 |
| Local variable 'value' could be declared final | 137 |
| Avoid if (x != y) ..; else ..; | 138 - 143 |
| Avoid using Literals in Conditional Statements | 138 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_objLog'. | 58 |
| Private field 'm_objData' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 64 |
| Private field 'm_objAttribs' could be made final; it is only initialized in the declaration or constructor. | 67 |
| Perhaps 'm_objAttribs' could be replaced by a local variable. | 67 |
| Private field 'm_objValues' could be made final; it is only initialized in the declaration or constructor. | 70 |
| Perhaps 'm_objValues' could be replaced by a local variable. | 70 |
| Parameter 'listener' is not assigned and could be declared final | 78 |
| It is a good practice to call super() in a constructor | 78 - 165 |
| Local variable 'iskBt' could be declared final | 83 |
| Local variable 'credBt' could be declared final | 86 |
| Local variable 'attribs' could be declared final | 95 |
| Local variable 'sortedAttribs' could be declared final | 96 |
| Local variable 'isEidCert' could be declared final | 99 |
| This statement may have some unnecessary parentheses | 99 |
| Found 'DU'-anomaly for variable 'isEidCert' (lines '99'-'165'). | 99 - 165 |
| Found 'DU'-anomaly for variable 'isEidCert' (lines '99'-'165'). | 99 - 165 |
| Avoid instantiating new objects inside loops | 103 |
| Found 'DD'-anomaly for variable 'eidAttrib' (lines '105'-'107'). | 105 - 107 |
| Found 'DD'-anomaly for variable 'eidAttrib' (lines '105'-'107'). | 105 - 107 |
| Avoid empty catch blocks | 108 |
| Avoid using Literals in Conditional Statements | 109 |
| Avoid using Literals in Conditional Statements | 115 |
| Avoid instantiating new objects inside loops | 117 |
| Parameter 'event' is not assigned and could be declared final | 134 |
| Local variable 'removeBt' could be declared final | 138 |
| Parameter 'event' is not assigned and could be declared final | 147 |
| Local variable 'embedded' could be declared final | 148 |
| Local variable 'panel' could be declared final | 149 |
| Local variable 'ta' could be declared final | 150 |
| Local variable 'detailBt' could be declared final | 160 |
| Violation | Line |
|---|---|
| Private field 'm_objEmptyLabel' could be made final; it is only initialized in the declaration or constructor. | 57 |
| Private field 'm_objStorage' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Private field 'm_objBtNext' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Private field 'm_objBtPrev' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Private field 'm_objCards' could be made final; it is only initialized in the declaration or constructor. | 69 |
| Parameter 'storage' is not assigned and could be declared final | 76 |
| It is a good practice to call super() in a constructor | 76 - 114 |
| Parameter 'event' is not assigned and could be declared final | 89 |
| Parameter 'event' is not assigned and could be declared final | 99 |
| Overridable method 'reload' called during object construction | 113 |
| Local variable 'items' could be declared final | 122 |
| Avoid using Literals in Conditional Statements | 128 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 134 |
| Avoid using Literals in Conditional Statements | 134 |
| Avoid instantiating new objects inside loops | 140 |
| Parameter 'value' is not assigned and could be declared final | 161 |
| Parameter 'parent' is not assigned and could be declared final | 161 |
| Parameter 'type' is not assigned and could be declared final | 161 |
| No need to check for null before an instanceof | 162 |
| Local variable 'instance' could be declared final | 163 |
| Violation | Line |
|---|---|
| Private field 'm_objCredList' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'm_objProofTable' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Parameter 'listener' is not assigned and could be declared final | 57 |
| Parameter 'storage' is not assigned and could be declared final | 57 |
| It is a good practice to call super() in a constructor | 57 - 71 |
| Parameter 'cmd' is not assigned and could be declared final | 77 |
| Parameter 'o' is not assigned and could be declared final | 77 |
| Local variable 'result' could be declared final | 78 |
| Switch statements should have a default label | 80 - 84 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 80 - 84 |
| Violation | Line |
|---|---|
| Parameter 'listener' is not assigned and could be declared final | 86 |
| It is a good practice to call super() in a constructor | 86 - 101 |
| Parameter 'credStore' is not assigned and could be declared final | 87 |
| Parameter 'client' is not assigned and could be declared final | 87 |
| Parameter 'request' is not assigned and could be declared final | 109 |
| Avoid if (x != y) ..; else ..; | 117 - 152 |
| Local variable 'body' could be declared final | 118 - 122 |
| Local variable 'listener' could be declared final | 124 - 147 |
| Parameter 'event' is not assigned and could be declared final | 127 |
| Local variable 'isreq' could be declared final | 155 - 156 |
| Local variable 'ires' could be declared final | 161 - 162 |
| Local variable 'idreq' could be declared final | 181 - 182 |
| Parameter 'request' is not assigned and could be declared final | 195 |
| Found 'DD'-anomaly for variable 'result' (lines '196'-'201'). | 196 - 201 |
| Avoid using Literals in Conditional Statements | 198 |
| Local variable 'certStruct' could be declared final | 199 |
| Local variable 'ipk' could be declared final | 200 |
| Parameter 'request' is not assigned and could be declared final | 213 |
| Avoid using Literals in Conditional Statements | 215 |
| Local variable 'certStruct' could be declared final | 216 |
| Local variable 'ipk' could be declared final | 217 |
| Avoid unused private methods such as 'displayError(String,String)'. | 231 |
| Parameter 'caption' is not assigned and could be declared final | 231 |
| Parameter 'msg' is not assigned and could be declared final | 231 |
| Violation | Line |
|---|---|
| Private field 'm_objData' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Parameter 'listener' is not assigned and could be declared final | 74 |
| Parameter 'proof' is not assigned and could be declared final | 74 |
| Local variable 'result' could be declared final | 94 |
| Local variable 'lSlash' could be declared final | 107 |
| Violation | Line |
|---|---|
| Private field 'm_objProverService' could be made final; it is only initialized in the declaration or constructor. | 72 |
| Parameter 'listener' is not assigned and could be declared final | 83 |
| It is a good practice to call super() in a constructor | 83 - 104 |
| Parameter 'proverService' is not assigned and could be declared final | 84 |
| Parameter 'request' is not assigned and could be declared final | 111 |
| Local variable 'parser' could be declared final | 115 |
| Avoid unused private methods such as 'displayError(ErrorCodeType)'. | 132 |
| Parameter 'code' is not assigned and could be declared final | 132 |
| Avoid using Literals in Conditional Statements | 133 |
| Avoid using Literals in Conditional Statements | 135 |
| Found 'DD'-anomaly for variable 'result' (lines '148'-'150'). | 148 - 150 |
| Found 'DD'-anomaly for variable 'result' (lines '148'-'150'). | 148 - 150 |
| Local variable 'listener' could be declared final | 151 - 183 |
| Parameter 'parent' is not assigned and could be declared final | 153 |
| Parameter 'type' is not assigned and could be declared final | 153 |
| Parameter 'value' is not assigned and could be declared final | 154 |
| No need to check for null before an instanceof | 163 |
| Parameter 'spec' is not assigned and could be declared final | 195 |
| Violation | Line |
|---|---|
| The class 'ProofRequestContent' has a Cyclomatic Complexity of 14 (Highest = 24). | 59 - 293 |
| Perhaps 'm_objParser' could be replaced by a local variable. | 70 |
| Private field 'm_objError' could be made final; it is only initialized in the declaration or constructor. | 79 |
| The constructor 'ProofRequestContent' has a Cyclomatic Complexity of 24. | 87 - 279 |
| The constructor with 2 parameters has an NCSS line count of 153 | 87 - 279 |
| Parameter 'clickListener' is not assigned and could be declared final | 87 |
| It is a good practice to call super() in a constructor | 87 - 279 |
| Parameter 'parser' is not assigned and could be declared final | 88 |
| Avoid using Literals in Conditional Statements | 100 |
| Local variable 'iter' could be declared final | 103 - 104 |
| Local variable 'vl' could be declared final | 105 |
| Local variable 'cert' could be declared final | 108 |
| Local variable 'certvl' could be declared final | 109 |
| Avoid instantiating new objects inside loops | 109 |
| Avoid instantiating new objects inside loops | 111 |
| Avoid instantiating new objects inside loops | 115 |
| Avoid instantiating new objects inside loops | 119 |
| Avoid instantiating new objects inside loops | 123 |
| Local variable 'iter' could be declared final | 135 - 136 |
| Local variable 'cert' could be declared final | 140 |
| Local variable 'certvl' could be declared final | 141 |
| Avoid instantiating new objects inside loops | 141 |
| Avoid instantiating new objects inside loops | 143 |
| Avoid instantiating new objects inside loops | 147 |
| Avoid instantiating new objects inside loops | 151 |
| Avoid instantiating new objects inside loops | 155 |
| Local variable 'attribs' could be declared final | 165 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 166 |
| Local variable 'attriter' could be declared final | 167 |
| Local variable 'attrvl' could be declared final | 168 |
| Local variable 'attrib' could be declared final | 170 |
| Local variable 'attrName' could be declared final | 172 |
| Avoid instantiating new objects inside loops | 172 |
| Avoid using Literals in Conditional Statements | 178 |
| Local variable 'ineqs' could be declared final | 187 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 188 |
| Local variable 'ineqiter' could be declared final | 191 |
| Local variable 'ineqvl' could be declared final | 192 |
| Local variable 'ineq' could be declared final | 194 |
| Local variable 'ineqName' could be declared final | 195 |
| Avoid instantiating new objects inside loops | 195 |
| Local variable 'verencs' could be declared final | 205 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 206 |
| Local variable 'venciter' could be declared final | 209 |
| Local variable 'vencvl' could be declared final | 210 |
| Local variable 'venc' could be declared final | 212 |
| Avoid instantiating new objects inside loops | 213 |
| Local variable 'vencName' could be declared final | 214 |
| Avoid instantiating new objects inside loops | 214 |
| Avoid if (x != y) ..; else ..; | 217 - 224 |
| Avoid using Literals in Conditional Statements | 217 |
| Avoid using Literals in Conditional Statements | 240 |
| Avoid using Literals in Conditional Statements | 241 |
| Avoid if (x != y) ..; else ..; | 243 - 254 |
| Avoid using Literals in Conditional Statements | 243 |
| Local variable 'buttons' could be declared final | 256 |
| Avoid using Literals in Conditional Statements | 257 |
| Avoid using Literals in Conditional Statements | 266 |
| Local variable 'error' could be declared final | 267 |
| Parameter 'event' is not assigned and could be declared final | 285 |
| Violation | Line |
|---|---|
| Private field 'm_objStore' could be made final; it is only initialized in the declaration or constructor. | 64 |
| Private field 'm_objDS' could be made final; it is only initialized in the declaration or constructor. | 67 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 70 |
| Private field 'm_objEmptyLabel' could be made final; it is only initialized in the declaration or constructor. | 73 |
| Private field 'm_objCredStore' could be made final; it is only initialized in the declaration or constructor. | 76 |
| Parameter 'credStore' is not assigned and could be declared final | 85 |
| Parameter 'listener' is not assigned and could be declared final | 85 |
| Parameter 'storage' is not assigned and could be declared final | 85 |
| It is a good practice to call super() in a constructor | 85 - 100 |
| Parameter 'o' is not assigned and could be declared final | 106 |
| Parameter 'type' is not assigned and could be declared final | 145 |
| Parameter 'restrict' is not assigned and could be declared final | 145 |
| Local variable 'items' could be declared final | 146 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 154 |
| Avoid using Literals in Conditional Statements | 154 |
| Avoid instantiating new objects inside loops | 161 |
| Parameter 'event' is not assigned and could be declared final | 177 |
| Parameter 'event' is not assigned and could be declared final | 186 |
| Local variable 'caption' could be declared final | 187 |
| Local variable 'spec' could be declared final | 203 |
| Local variable 'preq' could be declared final | 204 |
| Violation | Line |
|---|---|
| The class 'RevokeInfoContent' has a Cyclomatic Complexity of 6 (Highest = 14). | 57 - 245 |
| Private field 'm_objRevokeClient' could be made final; it is only initialized in the declaration or constructor. | 74 |
| Parameter 'listener' is not assigned and could be declared final | 85 |
| It is a good practice to call super() in a constructor | 85 - 106 |
| Parameter 'revocationService' is not assigned and could be declared final | 86 |
| The method 'triggerProofIncome' has a Cyclomatic Complexity of 14. | 113 - 179 |
| Parameter 'request' is not assigned and could be declared final | 113 |
| Found 'DU'-anomaly for variable 'ctx' (lines '116'-'179'). | 116 - 179 |
| Found 'DU'-anomaly for variable 'ctx' (lines '116'-'179'). | 116 - 179 |
| Found 'DU'-anomaly for variable 'ctx' (lines '116'-'179'). | 116 - 179 |
| Local variable 'invoker' could be declared final | 118 - 132 |
| Found 'DU'-anomaly for variable 'invoker' (lines '118'-'179'). | 118 - 179 |
| Found 'DU'-anomaly for variable 'invoker' (lines '118'-'179'). | 118 - 179 |
| Found 'DU'-anomaly for variable 'invoker' (lines '118'-'179'). | 118 - 179 |
| Parameter 'spec' is not assigned and could be declared final | 121 |
| Parameter 'spec' is not assigned and could be declared final | 128 |
| Local variable 'rresp' could be declared final | 134 |
| Avoid using Literals in Conditional Statements | 135 |
| Local variable 'vencs' could be declared final | 140 |
| Local variable 'certVals' could be declared final | 141 |
| If you run in Java5 and have concurrent access, you should use ConcurrentHashMap implementation | 141 |
| Found 'DU'-anomaly for variable 'certVals' (lines '141'-'179'). | 141 - 179 |
| Found 'DU'-anomaly for variable 'certVals' (lines '141'-'179'). | 141 - 179 |
| Found 'DU'-anomaly for variable 'certVals' (lines '141'-'179'). | 141 - 179 |
| Avoid if (x != y) ..; else ..; | 142 - 162 |
| Avoid using Literals in Conditional Statements | 142 |
| Local variable 'pkUri' could be declared final | 144 |
| Local variable 'id' could be declared final | 146 |
| Local variable 'name' could be declared final | 147 |
| Local variable 'value' could be declared final | 148 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 152 |
| Local variable 'done' could be declared final | 153 |
| Avoid using Literals in Conditional Statements | 169 |
| Parameter 'caption' is not assigned and could be declared final | 192 |
| Parameter 'msg' is not assigned and could be declared final | 192 |
| Avoid using Literals in Conditional Statements | 194 |
| Violation | Line |
|---|---|
| The class 'AbstractDefaultTable' has a Cyclomatic Complexity of 3 (Highest = 12). | 50 - 506 |
| This class has too many methods, consider refactoring it. | 51 - 506 |
| Avoid unused private fields such as 'm_objLock'. | 69 |
| The method init() has an NPath complexity of 385 | 121 - 195 |
| The method 'init' has a Cyclomatic Complexity of 12. | 121 - 195 |
| Parameter 'dataSource' is not assigned and could be declared final | 121 |
| Parameter 'caption' is not assigned and could be declared final | 121 |
| Parameter 'buttonListener' is not assigned and could be declared final | 122 |
| Parameter 'msgListener' is not assigned and could be declared final | 122 |
| Parameter 'showButtons' is not assigned and could be declared final | 122 |
| Parameter 'pageLength' is not assigned and could be declared final | 123 |
| Local variable 'bgrid' could be declared final | 153 |
| Local variable 'adddetails' could be declared final | 156 |
| Found 'DU'-anomaly for variable 'adddetails' (lines '156'-'195'). | 156 - 195 |
| Local variable 'editremove' could be declared final | 167 |
| Found 'DU'-anomaly for variable 'editremove' (lines '167'-'195'). | 167 - 195 |
| Parameter 'resource' is not assigned and could be declared final | 202 |
| An empty method in an abstract class should be abstract instead | 226 - 228 |
| An empty method in an abstract class should be abstract instead | 235 - 237 |
| An empty method in an abstract class should be abstract instead | 244 - 246 |
| An empty method in an abstract class should be abstract instead | 253 - 255 |
| An empty method in an abstract class should be abstract instead | 262 - 264 |
| Parameter 'show' is not assigned and could be declared final | 318 |
| Avoid using Literals in Conditional Statements | 320 |
| Avoid using Literals in Conditional Statements | 322 |
| Avoid using Literals in Conditional Statements | 324 |
| Avoid using Literals in Conditional Statements | 326 |
| Avoid using Literals in Conditional Statements | 328 |
| Parameter 'caption' is not assigned and could be declared final | 337 |
| Parameter 'caption' is not assigned and could be declared final | 348 |
| Parameter 'type' is not assigned and could be declared final | 348 |
| Parameter 'restrict' is not assigned and could be declared final | 348 |
| Parameter 'description' is not assigned and could be declared final | 371 |
| Parameter 'event' is not assigned and could be declared final | 379 |
| Found 'DD'-anomaly for variable 'isSelected' (lines '381'-'383'). | 381 - 383 |
| Found 'DD'-anomaly for variable 'isSelected' (lines '381'-'386'). | 381 - 386 |
| Avoid using Literals in Conditional Statements | 382 |
| Found 'DD'-anomaly for variable 'isSelected' (lines '383'-'386'). | 383 - 386 |
| Use bitwise inversion to invert boolean values | 386 |
| Assigning an Object to null is a code smell. Consider refactoring. | 391 |
| Avoid using Literals in Conditional Statements | 393 |
| Avoid using Literals in Conditional Statements | 396 |
| Avoid using Literals in Conditional Statements | 399 |
| Avoid using Literals in Conditional Statements | 409 |
| Avoid using Literals in Conditional Statements | 412 |
| Avoid using Literals in Conditional Statements | 415 |
| The method 'tranceive' has a Cyclomatic Complexity of 12. | 453 - 505 |
| Parameter 'cmd' is not assigned and could be declared final | 453 |
| Parameter 'o' is not assigned and could be declared final | 453 |
| Avoid using Literals in Conditional Statements | 454 |
| Switch statements should have a default label | 455 - 502 |
| Avoid using Literals in Conditional Statements | 459 |
| Avoid using Literals in Conditional Statements | 466 |
| These nested if statements could be combined | 467 - 471 |
| Deeply nested if..then statements are hard to read | 467 - 471 |
| Local variable 'item' could be declared final | 473 |
| Violation | Line |
|---|---|
| Private field 'm_objData' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Private field 'm_numTimeStamp' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Parameter 'data' is not assigned and could be declared final | 61 |
| Violation | Line |
|---|---|
| Private field 'm_objDebugTable' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'm_objDebugInfoArea' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'm_objExtDebugInfoArea' could be made final; it is only initialized in the declaration or constructor. | 47 |
| It is a good practice to call super() in a constructor | 52 - 60 |
| Parameter 'data' is not assigned and could be declared final | 67 |
| Parameter 'cmd' is not assigned and could be declared final | 75 |
| Parameter 'o' is not assigned and could be declared final | 75 |
| Avoid using Literals in Conditional Statements | 76 |
| Switch statements should have a default label | 77 - 93 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 77 - 93 |
| A high ratio of statements to labels in a switch statement. Consider refactoring. | 77 - 93 |
| Local variable 'idata' could be declared final | 81 |
| Avoid if (x != y) ..; else ..; | 84 - 89 |
| Avoid using Literals in Conditional Statements | 84 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'm_objLog'. | 45 |
| Private field 'm_objDS' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Private field 'm_objListener' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Parameter 'listener' is not assigned and could be declared final | 58 |
| It is a good practice to call super() in a constructor | 58 - 64 |
| Parameter 'o' is not assigned and could be declared final | 70 |
| Parameter 'type' is not assigned and could be declared final | 94 |
| Parameter 'restrict' is not assigned and could be declared final | 94 |
| Parameter 'data' is not assigned and could be declared final | 107 |
| Avoid using Literals in Conditional Statements | 108 |
| Parameter 'event' is not assigned and could be declared final | 119 |
| Document empty method | 127 - 128 |
| Parameter 'event' is not assigned and could be declared final | 127 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 42 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 47 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 57 - 569 |
| Parameter 'content' is not assigned and could be declared final | 116 |
| Local variable 'result' could be declared final | 117 |
| Parameter 'content' is not assigned and could be declared final | 129 |
| Local variable 'result' could be declared final | 130 |
| Parameter 'value' is not assigned and could be declared final | 144 |
| Parameter 'caption' is not assigned and could be declared final | 144 |
| Parameter 'listener' is not assigned and could be declared final | 145 |
| Local variable 'result' could be declared final | 146 |
| Parameter 'listener' is not assigned and could be declared final | 159 |
| Parameter 'iconOnly' is not assigned and could be declared final | 159 |
| Parameter 'listener' is not assigned and could be declared final | 171 |
| Parameter 'iconOnly' is not assigned and could be declared final | 172 |
| Parameter 'listener' is not assigned and could be declared final | 184 |
| Parameter 'iconOnly' is not assigned and could be declared final | 184 |
| Parameter 'listener' is not assigned and could be declared final | 196 |
| Parameter 'iconOnly' is not assigned and could be declared final | 196 |
| Parameter 'listener' is not assigned and could be declared final | 208 |
| Parameter 'iconOnly' is not assigned and could be declared final | 208 |
| Parameter 'listener' is not assigned and could be declared final | 220 |
| Parameter 'iconOnly' is not assigned and could be declared final | 220 |
| Parameter 'listener' is not assigned and could be declared final | 232 |
| Parameter 'iconOnly' is not assigned and could be declared final | 233 |
| Parameter 'listener' is not assigned and could be declared final | 245 |
| Parameter 'iconOnly' is not assigned and could be declared final | 245 |
| Parameter 'listener' is not assigned and could be declared final | 257 |
| Parameter 'iconOnly' is not assigned and could be declared final | 258 |
| Parameter 'listener' is not assigned and could be declared final | 270 |
| Parameter 'iconOnly' is not assigned and could be declared final | 271 |
| Parameter 'listener' is not assigned and could be declared final | 283 |
| Parameter 'iconOnly' is not assigned and could be declared final | 283 |
| Parameter 'listener' is not assigned and could be declared final | 295 |
| Parameter 'iconOnly' is not assigned and could be declared final | 295 |
| Parameter 'listener' is not assigned and could be declared final | 307 |
| Parameter 'iconOnly' is not assigned and could be declared final | 308 |
| Parameter 'listener' is not assigned and could be declared final | 320 |
| Parameter 'iconOnly' is not assigned and could be declared final | 321 |
| Parameter 'listener' is not assigned and could be declared final | 333 |
| Parameter 'iconOnly' is not assigned and could be declared final | 334 |
| Parameter 'showCaption' is not assigned and could be declared final | 347 |
| Parameter 'listener' is not assigned and could be declared final | 348 |
| Parameter 'showIcon' is not assigned and could be declared final | 348 |
| Parameter 'showCaption' is not assigned and could be declared final | 361 |
| Parameter 'listener' is not assigned and could be declared final | 362 |
| Parameter 'showIcon' is not assigned and could be declared final | 362 |
| Avoid unused method parameters such as 'showIcon'. | 377 - 389 |
| Parameter 'showCaption' is not assigned and could be declared final | 377 |
| Parameter 'icon' is not assigned and could be declared final | 378 |
| Parameter 'showIcon' is not assigned and could be declared final | 378 |
| Parameter 'caption' is not assigned and could be declared final | 378 |
| Parameter 'listener' is not assigned and could be declared final | 379 |
| Local variable 'result' could be declared final | 380 |
| Avoid using Literals in Conditional Statements | 384 |
| Avoid using Literals in Conditional Statements | 386 |
| Parameter 'icon' is not assigned and could be declared final | 400 |
| Parameter 'caption' is not assigned and could be declared final | 400 |
| Parameter 'listener' is not assigned and could be declared final | 401 |
| Parameter 'iconOnly' is not assigned and could be declared final | 401 |
| Found 'DD'-anomaly for variable 'result' (lines '402'-'404'). | 402 - 404 |
| Found 'DD'-anomaly for variable 'result' (lines '402'-'406'). | 402 - 406 |
| Avoid using Literals in Conditional Statements | 407 |
| Parameter 'caption' is not assigned and could be declared final | 422 |
| Parameter 'closeable' is not assigned and could be declared final | 423 |
| Parameter 'currentComponent' is not assigned and could be declared final | 423 |
| Parameter 'caption' is not assigned and could be declared final | 438 |
| Parameter 'closeable' is not assigned and could be declared final | 439 |
| Parameter 'height' is not assigned and could be declared final | 439 |
| Parameter 'width' is not assigned and could be declared final | 439 |
| Parameter 'currentComponent' is not assigned and could be declared final | 439 |
| Avoid using Literals in Conditional Statements | 445 |
| Avoid using Literals in Conditional Statements | 448 |
| Found 'DU'-anomaly for variable 'currentWindow' (lines '454'-'476'). | 454 - 476 |
| Found 'DU'-anomaly for variable 'currentWindow' (lines '454'-'476'). | 454 - 476 |
| Parameter 'e' is not assigned and could be declared final | 461 |
| Avoid using Literals in Conditional Statements | 464 |
| Avoid if (x != y) ..; else ..; | 471 - 474 |
| Avoid using Literals in Conditional Statements | 473 |
| Local variable 'listener' could be declared final | 486 - 506 |
| Parameter 'event' is not assigned and could be declared final | 489 |
| Avoid using Literals in Conditional Statements | 490 |
| Parameter 'request' is not assigned and could be declared final | 516 |
| Local variable 'result' could be declared final | 517 |
| Local variable 'sin' could be declared final | 520 |
| Avoid using Literals in Conditional Statements | 521 |
| Local variable 'br' could be declared final | 522 - 523 |
| Found 'DD'-anomaly for variable 'line' (lines '524'-'525'). | 524 - 525 |
| Avoid assignments in operands | 525 |
| Found 'DU'-anomaly for variable 'line' (lines '525'-'534'). | 525 - 534 |
| Parameter 'content' is not assigned and could be declared final | 543 |
| Parameter 'strUrl' is not assigned and could be declared final | 543 |
| Found 'DD'-anomaly for variable 'result' (lines '544'-'547'). | 544 - 547 |
| Local variable 'client' could be declared final | 546 |
| Violation | Line |
|---|---|
| Private field 'm_objBody' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Perhaps 'm_objBody' could be replaced by a local variable. | 41 |
| Private field 'm_objButtonOk' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'm_objButtonCancel' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Parameter 'listener' is not assigned and could be declared final | 55 |
| Parameter 'xhtmlBody' is not assigned and could be declared final | 55 |
| It is a good practice to call super() in a constructor | 55 - 77 |
| Local variable 'hl' could be declared final | 69 |
| Parameter 'listener' is not assigned and could be declared final | 84 |
